[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 118972: Don't have all the Thmeme color properties in the public api
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-06-27 12:24:39
Message-ID: 20140627122439.18724.10333 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118972/#review61082
-----------------------------------------------------------
Ship it!
Concept seems fine in general.
Check my comment before pushing.
src/declarativeimports/core/quicktheme.h
<https://git.reviewboard.kde.org/r/118972/#comment42537>
Doesn't redeclaring a signal in a subclass cause a massive warning at runtime?
We used to do it somewhere else.
I know it's needed for the Q_PROPERTIES because moc is rubbish but the only way I \
managed to solve this was to something like:
Q_SIGNALS:
void themeChangedProxy();
and changing all the properties to use this.
and in the ctor
connect(this, signal("themeChanged"), this, signal("themeChangedProxy"));
- David Edmundson
On June 27, 2014, 10:30 a.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118972/
> -----------------------------------------------------------
>
> (Updated June 27, 2014, 10:30 a.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> the color properties are remotely useful only when used from QML and risk to \
> explode in number in the future, it's not a good thing for a public c++ api.
> Also, they will become kinda deprecated as in largely replaced by the ColorRole \
> api. Too late to remove those properties completely, but still last days to move \
> them at least out of c++ api. (and in qml they could be removed in the future in a \
> 2.1 version of the import while still being present in 2.0 if needed)
> This moves the color properties is a theme subclass available only from QML (yes, \
> it basically reintroduces the old themeproxy concept, but i don't think it was \
> completely a good move to move everything in theme)
>
> Diffs
> -----
>
> src/declarativeimports/core/CMakeLists.txt e3d2f4e
> src/declarativeimports/core/corebindingsplugin.cpp ebd9fd7
> src/declarativeimports/core/quicktheme.h PRE-CREATION
> src/declarativeimports/core/quicktheme.cpp PRE-CREATION
> src/plasma/theme.h 0211f73
> src/plasma/theme.cpp c193807
>
> Diff: https://git.reviewboard.kde.org/r/118972/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118972/">https://git.reviewboard.kde.org/r/118972/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Concept seems fine in \
general. Check my comment before pushing.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118972/diff/1/?file=284935#file284935line179" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/core/quicktheme.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">179</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="nf">themeChanged</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Doesn't \
redeclaring a signal in a subclass cause a massive warning at runtime? We used to do \
it somewhere else.
I know it's needed for the Q_PROPERTIES because moc is rubbish but the only way I \
managed to solve this was to something like:
Q_SIGNALS:
void themeChangedProxy();
and changing all the properties to use this.
and in the ctor
connect(this, signal("themeChanged"), this, \
signal("themeChangedProxy"));
</pre>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On June 27th, 2014, 10:30 a.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated June 27, 2014, 10:30 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the color properties are remotely useful only when used from QML and \
risk to explode in number in the future, it's not a good thing for a public c++ \
api.
Also, they will become kinda deprecated as in largely replaced by the ColorRole api. \
Too late to remove those properties completely, but still last days to move them at \
least out of c++ api. (and in qml they could be removed in the future in a 2.1 \
version of the import while still being present in 2.0 if needed)
This moves the color properties is a theme subclass available only from QML (yes, it \
basically reintroduces the old themeproxy concept, but i don't think it was \
completely a good move to move everything in theme) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/CMakeLists.txt <span style="color: \
grey">(e3d2f4e)</span></li>
<li>src/declarativeimports/core/corebindingsplugin.cpp <span style="color: \
grey">(ebd9fd7)</span></li>
<li>src/declarativeimports/core/quicktheme.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/core/quicktheme.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/plasma/theme.h <span style="color: grey">(0211f73)</span></li>
<li>src/plasma/theme.cpp <span style="color: grey">(c193807)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118972/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic