'Re: Review Request 118366: Porting keyboard module to Framework5'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 118366: Porting keyboard module to Framework5
From:       "shivam makkar" <amourphious1992 () gmail ! com>
Date:       2014-06-20 21:25:02
Message-ID: 20140620212502.30212.9963 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118366/
-----------------------------------------------------------

(Updated June 20, 2014, 9:24 p.m.)

Review request for kde-workspace, KDE Frameworks and Andriy Rysin.

Repository: plasma-desktop

Description
-------

Removed deprecated statements and ported keyboard module to framework 5.

Diffs (updated)
-----

  kcms/keyboard/bindings.h c576455 
  kcms/keyboard/bindings.cpp 21541e0 
  kcms/keyboard/bindings.cpp 21541e0 
  kcms/keyboard/bindings.cpp 325dd3c 
  kcms/keyboard/flags.cpp b768586 
  kcms/keyboard/flags.cpp b768586 
  kcms/keyboard/flags.cpp 6d25443 
  kcms/keyboard/flags.cpp 3fb98e5 
  kcms/keyboard/iso_codes.h 6a33739 
  kcms/keyboard/iso_codes.cpp 3e3b210 
  kcms/keyboard/kcm_keyboard.cpp 42b7fe4 
  kcms/keyboard/kcm_keyboard.ui 0062d1c 
  kcms/keyboard/kcm_keyboard.ui 0062d1c 
  kcms/keyboard/kcm_keyboard_widget.h 657ddda 
  kcms/keyboard/kcm_keyboard_widget.cpp 21685eb 
  kcms/keyboard/kcm_keyboard_widget.cpp 21685eb 
  kcms/keyboard/kcm_keyboard_widget.cpp 2840e26 
  kcms/keyboard/kcm_keyboard_widget.cpp 9b0f584 
  kcms/keyboard/kcmmisc.h 411bdd2 
  kcms/keyboard/kcmmisc.h 411bdd2 
  kcms/keyboard/kcmmisc.h 1183fb1 
  kcms/keyboard/kcmmisc.cpp 6f787ea 
  kcms/keyboard/kcmmisc.cpp 6f787ea 
  kcms/keyboard/kcmmisc.cpp d14ac2e 
  kcms/keyboard/kcmmisc.cpp 3327ce5 
  kcms/keyboard/kcmmiscwidget.ui 37fbaf4 
  kcms/keyboard/kcmmiscwidget.ui 37fbaf4 
  kcms/keyboard/keyboard_config.h b86418d 
  kcms/keyboard/keyboard_config.cpp f3ff97c 
  kcms/keyboard/keyboard_config.cpp f3ff97c 
  kcms/keyboard/keyboard_config.cpp 49f059c 
  kcms/keyboard/keyboard_config.cpp a227a34 
  kcms/keyboard/keyboard_daemon.h 4edb968 
  kcms/keyboard/keyboard_daemon.cpp 25673b0 
  kcms/keyboard/keyboard_daemon.cpp 25673b0 
  kcms/keyboard/keyboard_daemon.cpp dcda1ec 
  kcms/keyboard/keyboard_hardware.cpp dca49b6 
  kcms/keyboard/keyboard_hardware.cpp dca49b6 
  kcms/keyboard/keyboard_hardware.cpp 9a61159 
  kcms/keyboard/layout_memory.h df8568c 
  kcms/keyboard/layout_memory.cpp 9e72361 
  kcms/keyboard/layout_memory.cpp 9e72361 
  kcms/keyboard/layout_memory.cpp d78e677 
  kcms/keyboard/layout_memory_persister.h 8c4b3c5 
  kcms/keyboard/layout_memory_persister.cpp 8a6118a 
  kcms/keyboard/layout_memory_persister.cpp 8a6118a 
  kcms/keyboard/layout_memory_persister.cpp 1dba024 
  kcms/keyboard/layout_widget.cpp e67b2d7 
  kcms/keyboard/layouts_menu.h db2f3ff 
  kcms/keyboard/layouts_menu.cpp fd436c4 
  kcms/keyboard/layouts_menu.cpp fd436c4 
  kcms/keyboard/layouts_menu.cpp e357c6a 
  kcms/keyboard/layouts_menu.cpp 7d4c4d6 
  kcms/keyboard/x11_helper.h 719b13f 
  kcms/keyboard/x11_helper.h 385ae28 
  kcms/keyboard/x11_helper.cpp 0e2806e 
  kcms/keyboard/x11_helper.cpp cbb2cfc 
  kcms/keyboard/xinput_helper.h 343d7ed 
  kcms/keyboard/xinput_helper.h 343d7ed 
  kcms/keyboard/xinput_helper.cpp b311579 
  kcms/keyboard/xinput_helper.cpp b311579 
  kcms/keyboard/xinput_helper.cpp b245e91 
  kcms/keyboard/xinput_helper.cpp 980338e 
  kcms/keyboard/xinput_helper.cpp 1c9604b 
  kcms/keyboard/xinput_helper.cpp 2b374ae 
  kcms/keyboard/xkb_helper.cpp 967399e 
  kcms/keyboard/xkb_rules.h 2be8562 
  kcms/keyboard/xkb_rules.cpp f09e675 

Diff: https://git.reviewboard.kde.org/r/118366/diff/

Testing
-------

Thanks,

shivam makkar

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118366/">https://git.reviewboard.kde.org/r/118366/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for kde-workspace, KDE Frameworks and Andriy Rysin.</div>
<div>By shivam makkar.</div>

<p style="color: grey;"><i>Updated June 20, 2014, 9:24 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed deprecated statements and ported \
keyboard module to framework 5.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/keyboard/bindings.h <span style="color: grey">(c576455)</span></li>

 <li>kcms/keyboard/bindings.cpp <span style="color: grey">(21541e0)</span></li>

 <li>kcms/keyboard/bindings.cpp <span style="color: grey">(21541e0)</span></li>

 <li>kcms/keyboard/bindings.cpp <span style="color: grey">(325dd3c)</span></li>

 <li>kcms/keyboard/flags.cpp <span style="color: grey">(b768586)</span></li>

 <li>kcms/keyboard/flags.cpp <span style="color: grey">(b768586)</span></li>

 <li>kcms/keyboard/flags.cpp <span style="color: grey">(6d25443)</span></li>

 <li>kcms/keyboard/flags.cpp <span style="color: grey">(3fb98e5)</span></li>

 <li>kcms/keyboard/iso_codes.h <span style="color: grey">(6a33739)</span></li>

 <li>kcms/keyboard/iso_codes.cpp <span style="color: grey">(3e3b210)</span></li>

 <li>kcms/keyboard/kcm_keyboard.cpp <span style="color: grey">(42b7fe4)</span></li>

 <li>kcms/keyboard/kcm_keyboard.ui <span style="color: grey">(0062d1c)</span></li>

 <li>kcms/keyboard/kcm_keyboard.ui <span style="color: grey">(0062d1c)</span></li>

 <li>kcms/keyboard/kcm_keyboard_widget.h <span style="color: grey">(657ddda)</span></li>

 <li>kcms/keyboard/kcm_keyboard_widget.cpp <span style="color: grey">(21685eb)</span></li>

 <li>kcms/keyboard/kcm_keyboard_widget.cpp <span style="color: grey">(21685eb)</span></li>

 <li>kcms/keyboard/kcm_keyboard_widget.cpp <span style="color: grey">(2840e26)</span></li>

 <li>kcms/keyboard/kcm_keyboard_widget.cpp <span style="color: grey">(9b0f584)</span></li>

 <li>kcms/keyboard/kcmmisc.h <span style="color: grey">(411bdd2)</span></li>

 <li>kcms/keyboard/kcmmisc.h <span style="color: grey">(411bdd2)</span></li>

 <li>kcms/keyboard/kcmmisc.h <span style="color: grey">(1183fb1)</span></li>

 <li>kcms/keyboard/kcmmisc.cpp <span style="color: grey">(6f787ea)</span></li>

 <li>kcms/keyboard/kcmmisc.cpp <span style="color: grey">(6f787ea)</span></li>

 <li>kcms/keyboard/kcmmisc.cpp <span style="color: grey">(d14ac2e)</span></li>

 <li>kcms/keyboard/kcmmisc.cpp <span style="color: grey">(3327ce5)</span></li>

 <li>kcms/keyboard/kcmmiscwidget.ui <span style="color: grey">(37fbaf4)</span></li>

 <li>kcms/keyboard/kcmmiscwidget.ui <span style="color: grey">(37fbaf4)</span></li>

 <li>kcms/keyboard/keyboard_config.h <span style="color: grey">(b86418d)</span></li>

 <li>kcms/keyboard/keyboard_config.cpp <span style="color: grey">(f3ff97c)</span></li>

 <li>kcms/keyboard/keyboard_config.cpp <span style="color: grey">(f3ff97c)</span></li>

 <li>kcms/keyboard/keyboard_config.cpp <span style="color: grey">(49f059c)</span></li>

 <li>kcms/keyboard/keyboard_config.cpp <span style="color: grey">(a227a34)</span></li>

 <li>kcms/keyboard/keyboard_daemon.h <span style="color: grey">(4edb968)</span></li>

 <li>kcms/keyboard/keyboard_daemon.cpp <span style="color: grey">(25673b0)</span></li>

 <li>kcms/keyboard/keyboard_daemon.cpp <span style="color: grey">(25673b0)</span></li>

 <li>kcms/keyboard/keyboard_daemon.cpp <span style="color: grey">(dcda1ec)</span></li>

 <li>kcms/keyboard/keyboard_hardware.cpp <span style="color: grey">(dca49b6)</span></li>

 <li>kcms/keyboard/keyboard_hardware.cpp <span style="color: grey">(dca49b6)</span></li>

 <li>kcms/keyboard/keyboard_hardware.cpp <span style="color: grey">(9a61159)</span></li>

 <li>kcms/keyboard/layout_memory.h <span style="color: grey">(df8568c)</span></li>

 <li>kcms/keyboard/layout_memory.cpp <span style="color: grey">(9e72361)</span></li>

 <li>kcms/keyboard/layout_memory.cpp <span style="color: grey">(9e72361)</span></li>

 <li>kcms/keyboard/layout_memory.cpp <span style="color: grey">(d78e677)</span></li>

 <li>kcms/keyboard/layout_memory_persister.h <span style="color: grey">(8c4b3c5)</span></li>

 <li>kcms/keyboard/layout_memory_persister.cpp <span style="color: grey">(8a6118a)</span></li>

 <li>kcms/keyboard/layout_memory_persister.cpp <span style="color: grey">(8a6118a)</span></li>

 <li>kcms/keyboard/layout_memory_persister.cpp <span style="color: grey">(1dba024)</span></li>

 <li>kcms/keyboard/layout_widget.cpp <span style="color: grey">(e67b2d7)</span></li>

 <li>kcms/keyboard/layouts_menu.h <span style="color: grey">(db2f3ff)</span></li>

 <li>kcms/keyboard/layouts_menu.cpp <span style="color: grey">(fd436c4)</span></li>

 <li>kcms/keyboard/layouts_menu.cpp <span style="color: grey">(fd436c4)</span></li>

 <li>kcms/keyboard/layouts_menu.cpp <span style="color: grey">(e357c6a)</span></li>

 <li>kcms/keyboard/layouts_menu.cpp <span style="color: grey">(7d4c4d6)</span></li>

 <li>kcms/keyboard/x11_helper.h <span style="color: grey">(719b13f)</span></li>

 <li>kcms/keyboard/x11_helper.h <span style="color: grey">(385ae28)</span></li>

 <li>kcms/keyboard/x11_helper.cpp <span style="color: grey">(0e2806e)</span></li>

 <li>kcms/keyboard/x11_helper.cpp <span style="color: grey">(cbb2cfc)</span></li>

 <li>kcms/keyboard/xinput_helper.h <span style="color: grey">(343d7ed)</span></li>

 <li>kcms/keyboard/xinput_helper.h <span style="color: grey">(343d7ed)</span></li>

 <li>kcms/keyboard/xinput_helper.cpp <span style="color: grey">(b311579)</span></li>

 <li>kcms/keyboard/xinput_helper.cpp <span style="color: grey">(b311579)</span></li>

 <li>kcms/keyboard/xinput_helper.cpp <span style="color: grey">(b245e91)</span></li>

 <li>kcms/keyboard/xinput_helper.cpp <span style="color: grey">(980338e)</span></li>

 <li>kcms/keyboard/xinput_helper.cpp <span style="color: grey">(1c9604b)</span></li>

 <li>kcms/keyboard/xinput_helper.cpp <span style="color: grey">(2b374ae)</span></li>

 <li>kcms/keyboard/xkb_helper.cpp <span style="color: grey">(967399e)</span></li>

 <li>kcms/keyboard/xkb_rules.h <span style="color: grey">(2be8562)</span></li>

 <li>kcms/keyboard/xkb_rules.cpp <span style="color: grey">(f09e675)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118366/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 