'Re: Review Request 118366: Porting keyboard module to Framework5'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 118366: Porting keyboard module to Framework5
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2014-06-19 23:43:02
Message-ID: 20140619234302.30840.94850 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118366/#review60569
-----------------------------------------------------------

kcms/keyboard/bindings.cpp
<https://git.reviewboard.kde.org/r/118366/#comment42272>

    Use qCDebug? Using qDebug alone only means torrents of debug output that nobody will ever read.

kcms/keyboard/flags.cpp
<https://git.reviewboard.kde.org/r/118366/#comment42273>

    remove?

kcms/keyboard/flags.cpp
<https://git.reviewboard.kde.org/r/118366/#comment42274>

    wtf happened here? xD

kcms/keyboard/kcmmisc.cpp
<https://git.reviewboard.kde.org/r/118366/#comment42275>

    please, don't add commented code.

kcms/keyboard/kcmmisc.cpp
<https://git.reviewboard.kde.org/r/118366/#comment42276>

    I wouldn't do coding style changes while coding.

- Aleix Pol Gonzalez

On June 19, 2014, 6:48 p.m., shivam makkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118366/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 6:48 p.m.)
> 
> 
> Review request for kde-workspace, KDE Frameworks and Andriy Rysin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Removed deprecated statements and ported keyboard module to framework 5.
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/bindings.cpp 21541e0 
>   kcms/keyboard/bindings.cpp 21541e0 
>   kcms/keyboard/flags.cpp b768586 
>   kcms/keyboard/flags.cpp b768586 
>   kcms/keyboard/flags.cpp 6d25443 
>   kcms/keyboard/flags.cpp 3fb98e5 
>   kcms/keyboard/kcm_keyboard.ui 0062d1c 
>   kcms/keyboard/kcm_keyboard.ui 0062d1c 
>   kcms/keyboard/kcm_keyboard_widget.cpp 21685eb 
>   kcms/keyboard/kcm_keyboard_widget.cpp 21685eb 
>   kcms/keyboard/kcmmisc.h 411bdd2 
>   kcms/keyboard/kcmmisc.h 411bdd2 
>   kcms/keyboard/kcmmisc.cpp 6f787ea 
>   kcms/keyboard/kcmmisc.cpp 6f787ea 
>   kcms/keyboard/kcmmisc.cpp d14ac2e 
>   kcms/keyboard/kcmmiscwidget.ui 37fbaf4 
>   kcms/keyboard/kcmmiscwidget.ui 37fbaf4 
>   kcms/keyboard/keyboard_config.cpp f3ff97c 
>   kcms/keyboard/keyboard_config.cpp f3ff97c 
>   kcms/keyboard/keyboard_config.cpp 49f059c 
>   kcms/keyboard/keyboard_daemon.cpp 25673b0 
>   kcms/keyboard/keyboard_daemon.cpp 25673b0 
>   kcms/keyboard/keyboard_hardware.cpp dca49b6 
>   kcms/keyboard/keyboard_hardware.cpp dca49b6 
>   kcms/keyboard/layout_memory.cpp 9e72361 
>   kcms/keyboard/layout_memory.cpp 9e72361 
>   kcms/keyboard/layout_memory_persister.cpp 8a6118a 
>   kcms/keyboard/layout_memory_persister.cpp 8a6118a 
>   kcms/keyboard/layouts_menu.cpp fd436c4 
>   kcms/keyboard/layouts_menu.cpp fd436c4 
>   kcms/keyboard/layouts_menu.cpp e357c6a 
>   kcms/keyboard/x11_helper.h 719b13f 
>   kcms/keyboard/x11_helper.cpp 0e2806e 
>   kcms/keyboard/xinput_helper.h 343d7ed 
>   kcms/keyboard/xinput_helper.h 343d7ed 
>   kcms/keyboard/xinput_helper.cpp b311579 
>   kcms/keyboard/xinput_helper.cpp b311579 
>   kcms/keyboard/xinput_helper.cpp b245e91 
>   kcms/keyboard/xinput_helper.cpp 980338e 
> 
> Diff: https://git.reviewboard.kde.org/r/118366/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> shivam makkar
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118366/">https://git.reviewboard.kde.org/r/118366/</a>
     </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/118366/diff/4/?file=276644#file276644line113" style="color: \
black; font-weight: bold; text-decoration: underline;">kcms/keyboard/bindings.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KeyboardLayoutActionCollection::setLayoutShortcuts(QList&lt;LayoutUnit&gt;&amp; layoutUnits, const Rules* \
rules)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">112</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "><span class="hl"><span class="tb">	</span></span><span class="n"><span \
class="hl">k</span>Debug</span><span class="p">()</span> <span class="o">&lt;&lt;</span> <span \
class="s">&quot;Cleaning component shortcuts on save&quot;</span> <span class="o">&lt;&lt;</span> <span \
class="n">KGlobalAccel</span><span class="o">::</span><span class="n">cleanComponent</span><span \
class="p">(</span><span class="n">COMPONENT_NAME</span><span class="p">);</span></pre></td>  <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">113</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="hl">    </span><span class="n"><span \
class="hl">q</span>Debug</span><span class="p">()</span> <span class="o">&lt;&lt;</span> <span \
class="s">&quot;Cleaning component shortcuts on save&quot;</span> <span class="o">&lt;&lt;</span> <span \
class="n">KGlobalAccel</span><span class="o">::</span><span class="n">cleanComponent</span><span \
class="p">(</span><span class="n">COMPONENT_NAME</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Use qCDebug? Using qDebug alone only means torrents of \
debug output that nobody will ever read.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/118366/diff/4/?file=276646#file276646line21" style="color: black; \
font-weight: bold; text-decoration: underline;">kcms/keyboard/flags.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">21</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "><span class="cp">#include &lt;kdebug.h&gt;</span></pre></td>  <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">21</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "><span class="c1"><span class="hl">//</span>#include &lt;kdebug.h&gt;</span></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">remove?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/118366/diff/4/?file=276649#file276649line22" style="color: black; \
font-weight: bold; text-decoration: underline;">kcms/keyboard/flags.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">22</font></th>  <td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "><span class="o">=======</span></pre></td>  <th bgcolor="#ebb1ba" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>  <td \
bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">wtf happened here? xD</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/118366/diff/4/?file=276656#file276656line134" style="color: \
black; font-weight: bold; text-decoration: underline;">kcms/keyboard/kcmmisc.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int  \
KCMiscKeyboardWidget::getClick()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td>  <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">134</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="c1">//qDebug()&lt;&lt;&quot;button: &quot;&lt;&lt;checked-&gt;text();</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">please, don&#39;t add commented code.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/118366/diff/4/?file=276658#file276658line68" style="color: black; \
font-weight: bold; text-decoration: underline;">kcms/keyboard/kcmmisc.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KCMiscKeyboardWidget::KCMiscKeyboardWidget(QWidget *parent)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">68</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; ">  <span class="k">for</span><span class="p">(</span><span class="kt">int</span> <span \
class="n">i</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span> <span \
class="n">i</span> <span class="o">&lt;</span> <span class="n">btns</span><span class="p">.</span><span \
class="n">size</span><span class="p">();</span> <span class="n">i</span><span class="o">++</span><span \
class="p">){</span></pre></td>  <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; \
border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th>  <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">  <span class="k">for</span> \
<span class="p">(</span><span class="kt">int</span> <span class="n">i</span> <span class="o">=</span> \
<span class="mi">0</span><span class="p">;</span> <span class="n">i</span> <span class="o">&lt;</span> \
<span class="n">btns</span><span class="p">.</span><span class="n">size</span><span class="p">();</span> \
<span class="n">i</span><span class="o">++</span><span class="p">)</span> <span \
class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">I wouldn&#39;t do coding style changes while \
coding.</pre> </div>
<br />

<p>- Aleix Pol Gonzalez</p>

<br />
<p>On June 19th, 2014, 6:48 p.m. UTC, shivam makkar wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for kde-workspace, KDE Frameworks and Andriy Rysin.</div>
<div>By shivam makkar.</div>

<p style="color: grey;"><i>Updated June 19, 2014, 6:48 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed deprecated statements and ported \
keyboard module to framework 5.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/keyboard/bindings.cpp <span style="color: grey">(21541e0)</span></li>

 <li>kcms/keyboard/bindings.cpp <span style="color: grey">(21541e0)</span></li>

 <li>kcms/keyboard/flags.cpp <span style="color: grey">(b768586)</span></li>

 <li>kcms/keyboard/flags.cpp <span style="color: grey">(b768586)</span></li>

 <li>kcms/keyboard/flags.cpp <span style="color: grey">(6d25443)</span></li>

 <li>kcms/keyboard/flags.cpp <span style="color: grey">(3fb98e5)</span></li>

 <li>kcms/keyboard/kcm_keyboard.ui <span style="color: grey">(0062d1c)</span></li>

 <li>kcms/keyboard/kcm_keyboard.ui <span style="color: grey">(0062d1c)</span></li>

 <li>kcms/keyboard/kcm_keyboard_widget.cpp <span style="color: grey">(21685eb)</span></li>

 <li>kcms/keyboard/kcm_keyboard_widget.cpp <span style="color: grey">(21685eb)</span></li>

 <li>kcms/keyboard/kcmmisc.h <span style="color: grey">(411bdd2)</span></li>

 <li>kcms/keyboard/kcmmisc.h <span style="color: grey">(411bdd2)</span></li>

 <li>kcms/keyboard/kcmmisc.cpp <span style="color: grey">(6f787ea)</span></li>

 <li>kcms/keyboard/kcmmisc.cpp <span style="color: grey">(6f787ea)</span></li>

 <li>kcms/keyboard/kcmmisc.cpp <span style="color: grey">(d14ac2e)</span></li>

 <li>kcms/keyboard/kcmmiscwidget.ui <span style="color: grey">(37fbaf4)</span></li>

 <li>kcms/keyboard/kcmmiscwidget.ui <span style="color: grey">(37fbaf4)</span></li>

 <li>kcms/keyboard/keyboard_config.cpp <span style="color: grey">(f3ff97c)</span></li>

 <li>kcms/keyboard/keyboard_config.cpp <span style="color: grey">(f3ff97c)</span></li>

 <li>kcms/keyboard/keyboard_config.cpp <span style="color: grey">(49f059c)</span></li>

 <li>kcms/keyboard/keyboard_daemon.cpp <span style="color: grey">(25673b0)</span></li>

 <li>kcms/keyboard/keyboard_daemon.cpp <span style="color: grey">(25673b0)</span></li>

 <li>kcms/keyboard/keyboard_hardware.cpp <span style="color: grey">(dca49b6)</span></li>

 <li>kcms/keyboard/keyboard_hardware.cpp <span style="color: grey">(dca49b6)</span></li>

 <li>kcms/keyboard/layout_memory.cpp <span style="color: grey">(9e72361)</span></li>

 <li>kcms/keyboard/layout_memory.cpp <span style="color: grey">(9e72361)</span></li>

 <li>kcms/keyboard/layout_memory_persister.cpp <span style="color: grey">(8a6118a)</span></li>

 <li>kcms/keyboard/layout_memory_persister.cpp <span style="color: grey">(8a6118a)</span></li>

 <li>kcms/keyboard/layouts_menu.cpp <span style="color: grey">(fd436c4)</span></li>

 <li>kcms/keyboard/layouts_menu.cpp <span style="color: grey">(fd436c4)</span></li>

 <li>kcms/keyboard/layouts_menu.cpp <span style="color: grey">(e357c6a)</span></li>

 <li>kcms/keyboard/x11_helper.h <span style="color: grey">(719b13f)</span></li>

 <li>kcms/keyboard/x11_helper.cpp <span style="color: grey">(0e2806e)</span></li>

 <li>kcms/keyboard/xinput_helper.h <span style="color: grey">(343d7ed)</span></li>

 <li>kcms/keyboard/xinput_helper.h <span style="color: grey">(343d7ed)</span></li>

 <li>kcms/keyboard/xinput_helper.cpp <span style="color: grey">(b311579)</span></li>

 <li>kcms/keyboard/xinput_helper.cpp <span style="color: grey">(b311579)</span></li>

 <li>kcms/keyboard/xinput_helper.cpp <span style="color: grey">(b245e91)</span></li>

 <li>kcms/keyboard/xinput_helper.cpp <span style="color: grey">(980338e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118366/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 