[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 118690: Introduce a KLocalizedTranslator
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2014-06-17 16:24:09
Message-ID: 20140617162409.3733.79699 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118690/#review60286
-----------------------------------------------------------
Ship it!
Independent from the (needed) change for "uic -tr i18n". Can go in IMO.
- Kevin Ottens
On June 12, 2014, 8:55 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118690/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 8:55 a.m.)
>
>
> Review request for KDE Frameworks, Aurélien Gâteau and Chusslove Illich.
>
>
> Repository: ki18n
>
>
> Description
> -------
>
> Introduce a KLocalizedTranslator
>
> The KLocalizedTranslator is a QTranslator subclass which can delegate
> to ki18n for translations. This class allows to translate text which
> can only use Qt's translation system with ki18n.
>
>
> Diffs
> -----
>
> autotests/klocalizedstringtest.h 52b6248270e7d117855cb96c5d3d8582d89a99b0
> autotests/klocalizedstringtest.cpp e4e97ce92224f8886705c39091a5f07ea3a209d1
> src/CMakeLists.txt 09490e54ecd2126873482b187b17642c57ca7d28
> src/klocalizedtranslator.h PRE-CREATION
> src/klocalizedtranslator.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/118690/diff/
>
>
> Testing
> -------
>
> see added unit test and class already used in (and implemented for) KWin.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118690/">https://git.reviewboard.kde.org/r/118690/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Independent from the \
(needed) change for "uic -tr i18n". Can go in IMO.</pre> <br />
<p>- Kevin Ottens</p>
<br />
<p>On June 12th, 2014, 8:55 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks, Aurélien Gâteau and Chusslove Illich.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated June 12, 2014, 8:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Introduce a KLocalizedTranslator
The KLocalizedTranslator is a QTranslator subclass which can delegate
to ki18n for translations. This class allows to translate text which
can only use Qt's translation system with ki18n.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see added unit test and class already used in (and implemented for) \
KWin.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/klocalizedstringtest.h <span style="color: \
grey">(52b6248270e7d117855cb96c5d3d8582d89a99b0)</span></li>
<li>autotests/klocalizedstringtest.cpp <span style="color: \
grey">(e4e97ce92224f8886705c39091a5f07ea3a209d1)</span></li>
<li>src/CMakeLists.txt <span style="color: \
grey">(09490e54ecd2126873482b187b17642c57ca7d28)</span></li>
<li>src/klocalizedtranslator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/klocalizedtranslator.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118690/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic