[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 118498: Make ECM language-independent again, but make the tests use C
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2014-06-17 16:22:04
Message-ID: 20140617162204.3734.73639 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118498/#review60285
-----------------------------------------------------------
Ship it!
Looks fine to me.
- Kevin Ottens
On June 15, 2014, 4:13 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118498/
> -----------------------------------------------------------
>
> (Updated June 15, 2014, 4:13 p.m.)
>
>
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, Christophe \
> Giboudeaux, Nicolás Alvarez, and Allen Winter.
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Provide an option to exclude the tests
>
> While the tests in ECM are not "built" as such (at least, not until they
> are run), disabling the tests might be desirable to avoid the compiler
> checks and to make the whole build process architecture-independent.
>
> Make ECM language-independent again, but make the tests use C
>
> Setting the language for ECM's project() call to C had unanticipated
> side-effects - notably that the installed version file required the
> architecture to match the one used at build time.
>
> Instead, we make the tests a sub-project, setting up C as the language
> there (since most of the tests do use C, albeit slightly indirectly).
>
>
> Diffs
> -----
>
> CMakeLists.txt df0759f18f1ed091b43128c1c5844aead560fe5b
> tests/CMakeLists.txt dfcc252a4e723d7376f87153adcd23d00dbc7846
>
> Diff: https://git.reviewboard.kde.org/r/118498/diff/
>
>
> Testing
> -------
>
> Configures properly, tests pass. Visually inspected ECMConfigVersion.cmake file to \
> see that it will return before the architecture check.
>
> Thanks,
>
> Alex Merry
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118498/">https://git.reviewboard.kde.org/r/118498/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine to me.</pre> \
<br />
<p>- Kevin Ottens</p>
<br />
<p>On June 15th, 2014, 4:13 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Build System, Extra Cmake Modules, KDE Frameworks, Christophe \
Giboudeaux, Nicolás Alvarez, and Allen Winter.</div> <div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated June 15, 2014, 4:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Provide an option to exclude the tests
While the tests in ECM are not "built" as such (at least, not until they
are run), disabling the tests might be desirable to avoid the compiler
checks and to make the whole build process architecture-independent.
Make ECM language-independent again, but make the tests use C
Setting the language for ECM's project() call to C had unanticipated
side-effects - notably that the installed version file required the
architecture to match the one used at build time.
Instead, we make the tests a sub-project, setting up C as the language
there (since most of the tests do use C, albeit slightly indirectly).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Configures properly, tests pass. Visually inspected \
ECMConfigVersion.cmake file to see that it will return before the architecture \
check.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(df0759f18f1ed091b43128c1c5844aead560fe5b)</span></li>
<li>tests/CMakeLists.txt <span style="color: \
grey">(dfcc252a4e723d7376f87153adcd23d00dbc7846)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118498/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic