'Re: Review Request 118740: Use standard message box icon size in password dialogs'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 118740: Use standard message box icon size in password dialogs
From:       "Kevin Ottens" <ervin () kde ! org>
Date:       2014-06-17 16:20:48
Message-ID: 20140617162048.3734.66980 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118740/#review60283
-----------------------------------------------------------

Ship it!

Ship It!

- Kevin Ottens

On June 14, 2014, 11:11 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118740/
> -----------------------------------------------------------
> 
> (Updated June 14, 2014, 11:11 a.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Bugs: 336141
> https://bugs.kde.org/show_bug.cgi?id=336141
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> In KDE 4, we used hard coded sizes of 128 or 96 pixels to make sure the user \
> notices the importance of the dialogs. 
> This patch changes it to use QStyle standard sizes for message box icons. If we \
> want to continue using larger icon sizes for our platform, we can change them in \
> our QStyle. 
> 
> Diffs
> -----
> 
> src/knewpassworddialog.cpp 7fe3df2 
> src/kpassworddialog.cpp 88c821e 
> 
> Diff: https://git.reviewboard.kde.org/r/118740/diff/
> 
> 
> Testing
> -------
> 
> None, I still do not have a KF5 setup...
> 
> 
> Thanks,
> 
> Christoph Feck
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118740/">https://git.reviewboard.kde.org/r/118740/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Kevin Ottens</p>

<br />
<p>On June 14th, 2014, 11:11 a.m. UTC, Christoph Feck wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks and David Edmundson.</div>
<div>By Christoph Feck.</div>

<p style="color: grey;"><i>Updated June 14, 2014, 11:11 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=336141">336141</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In KDE 4, we used hard coded sizes of 128 or 96 pixels to make sure the \
user notices the importance of the dialogs.

This patch changes it to use QStyle standard sizes for message box icons. If we want \
to continue using larger icon sizes for our platform, we can change them in our \
QStyle.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">None, I still do not have a KF5 setup...</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/knewpassworddialog.cpp <span style="color: grey">(7fe3df2)</span></li>

 <li>src/kpassworddialog.cpp <span style="color: grey">(88c821e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118740/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 