[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 117974: Some more KArchive examples
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2014-06-17 16:12:03
Message-ID: 20140617161203.3734.57417 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117974/#review60278
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On June 6, 2014, 7:15 p.m., Maarten De Meyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117974/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 7:15 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: karchive
>
>
> Description
> -------
>
> 2 extra examples on how to use the KArchive framework. Together with the 2 we \
> already have most of the basic usage is covered.
> unzipper: Shows how to extract files from an archive
> bzip2gzip: Example about KCompressionDevice
>
> They are BSD licensed because I consider that a good license for examples. I \
> wouldn't mind changing to GPL. Please let me know how they could be improved.
> Readability, comments, variable naming, too simple?
>
>
> Diffs
> -----
>
> examples/bzip2gzip/CMakeLists.txt PRE-CREATION
> examples/bzip2gzip/main.cpp PRE-CREATION
> examples/unzipper/CMakeLists.txt PRE-CREATION
> examples/unzipper/main.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/117974/diff/
>
>
> Testing
> -------
>
> Builds and runs ok.
> Easy to read and comprehend. (imho)
>
>
> Thanks,
>
> Maarten De Meyer
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117974/">https://git.reviewboard.kde.org/r/117974/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Kevin Ottens</p>
<br />
<p>On June 6th, 2014, 7:15 p.m. UTC, Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated June 6, 2014, 7:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
karchive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">2 extra examples on how to use the KArchive framework. Together with the \
2 we already have most of the basic usage is covered.
unzipper: Shows how to extract files from an archive
bzip2gzip: Example about KCompressionDevice
They are BSD licensed because I consider that a good license for examples. I \
wouldn't mind changing to GPL. Please let me know how they could be improved.
Readability, comments, variable naming, too simple?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds and runs ok. Easy to read and comprehend. (imho)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>examples/bzip2gzip/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>examples/bzip2gzip/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>examples/unzipper/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>examples/unzipper/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117974/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic