'Re: Review Request 118666: Simple Cleanups'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 118666: Simple Cleanups
From:       "Thomas Braxton" <kde.braxton () gmail ! com>
Date:       2014-06-12 22:56:58
Message-ID: 20140612225658.7098.85102 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118666/
-----------------------------------------------------------

(Updated June 12, 2014, 10:56 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and Matthew Dawson.

Repository: kconfig

Description
-------

Simple Cleanups
- use Q_NULLPTR instead of 0 or NULL
- simplify some foreach loops
- use QStringLiteral in a few places
- added a few consts

Diffs
-----

  autotests/kconfig_compiler/kconfigcompiler_test.cpp 40173ee7e4f691d04c69877d191e0d035b4bb2e0 
  autotests/kconfigloadertest.cpp 451d636e4e584a97d897634b1db1459b47e12355 
  src/core/kconfig.h d27eebe7c41cb433b1808882c53cbf7b4c870950 
  src/core/kconfig.cpp ea9746c001e235529a1cdd5865b9e1b5c129b56a 
  src/core/kconfigbackend.cpp 90655facb49ebb1702fa1635ae5db3fc11fc31a3 
  src/core/kconfigdata.h e57becb24936865d009a700892893049b3e079f1 
  src/core/kconfiggroup.h 3c4bce8433e3c5d4cb2d9fdd111a43f04cf3c295 
  src/core/kconfiggroup.cpp 6f609baefec5beaf38fdfedd6d192b395e3f8acb 
  src/core/kconfigini.cpp df834f57fc44bbf9f4f28f1bc4eb5717e2ff1cee 
  src/core/kcoreconfigskeleton.h bb9c1cf936b87e2456726a2bb3428be42558b39f 
  src/gui/kconfiggroupgui.cpp a14c204c143b38189f042c37ccbe1bf6355a2a18 
  src/gui/kconfiggui.cpp 1eee8ce50fd660f11cad53c2a493072317e1f331 
  src/gui/kconfigloader.h 36eb182fbf1c241a043566a13d7c6c123a6e455f 
  src/gui/kconfigloader.cpp 1dd9e7fc44a367165fedc2e7760c8b524ecd210e 
  src/gui/kconfigskeleton.h f87eef6e5268a3b4e93fd733f70a2bdd4c4be753 
  src/kconf_update/kconf_update.cpp 829d35e61da3d303539044d0dc652cc99dec35a2 
  src/kconf_update/kconfigutils.cpp f2663e1316ec2cdbef303385787d14406e02f4a1 

Diff: https://git.reviewboard.kde.org/r/118666/diff/

Testing
-------

All tests still pass

Thanks,

Thomas Braxton

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118666/">https://git.reviewboard.kde.org/r/118666/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Matthew Dawson.</div>
<div>By Thomas Braxton.</div>

<p style="color: grey;"><i>Updated June 12, 2014, 10:56 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">Simple Cleanups
- use Q_NULLPTR instead of 0 or NULL
- simplify some foreach loops
- use QStringLiteral in a few places
- added a few consts</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All tests still pass</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kconfig_compiler/kconfigcompiler_test.cpp <span style="color: \
grey">(40173ee7e4f691d04c69877d191e0d035b4bb2e0)</span></li>

 <li>autotests/kconfigloadertest.cpp <span style="color: \
grey">(451d636e4e584a97d897634b1db1459b47e12355)</span></li>

 <li>src/core/kconfig.h <span style="color: \
grey">(d27eebe7c41cb433b1808882c53cbf7b4c870950)</span></li>

 <li>src/core/kconfig.cpp <span style="color: \
grey">(ea9746c001e235529a1cdd5865b9e1b5c129b56a)</span></li>

 <li>src/core/kconfigbackend.cpp <span style="color: \
grey">(90655facb49ebb1702fa1635ae5db3fc11fc31a3)</span></li>

 <li>src/core/kconfigdata.h <span style="color: \
grey">(e57becb24936865d009a700892893049b3e079f1)</span></li>

 <li>src/core/kconfiggroup.h <span style="color: \
grey">(3c4bce8433e3c5d4cb2d9fdd111a43f04cf3c295)</span></li>

 <li>src/core/kconfiggroup.cpp <span style="color: \
grey">(6f609baefec5beaf38fdfedd6d192b395e3f8acb)</span></li>

 <li>src/core/kconfigini.cpp <span style="color: \
grey">(df834f57fc44bbf9f4f28f1bc4eb5717e2ff1cee)</span></li>

 <li>src/core/kcoreconfigskeleton.h <span style="color: \
grey">(bb9c1cf936b87e2456726a2bb3428be42558b39f)</span></li>

 <li>src/gui/kconfiggroupgui.cpp <span style="color: \
grey">(a14c204c143b38189f042c37ccbe1bf6355a2a18)</span></li>

 <li>src/gui/kconfiggui.cpp <span style="color: \
grey">(1eee8ce50fd660f11cad53c2a493072317e1f331)</span></li>

 <li>src/gui/kconfigloader.h <span style="color: \
grey">(36eb182fbf1c241a043566a13d7c6c123a6e455f)</span></li>

 <li>src/gui/kconfigloader.cpp <span style="color: \
grey">(1dd9e7fc44a367165fedc2e7760c8b524ecd210e)</span></li>

 <li>src/gui/kconfigskeleton.h <span style="color: \
grey">(f87eef6e5268a3b4e93fd733f70a2bdd4c4be753)</span></li>

 <li>src/kconf_update/kconf_update.cpp <span style="color: \
grey">(829d35e61da3d303539044d0dc652cc99dec35a2)</span></li>

 <li>src/kconf_update/kconfigutils.cpp <span style="color: \
grey">(f2663e1316ec2cdbef303385787d14406e02f4a1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118666/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 