[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons
From: "Dominik Haumann" <dhaumann () kde ! org>
Date: 2014-06-04 12:36:09
Message-ID: 20140604123609.16449.5865 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 4, 2014, 11:41 a.m., Dominik Haumann wrote:
> > What about adding something like this to Qt ?
>
> Christoph Feck wrote:
> First, I was thinking the same. The efforts with KF5 work was to get as much \
> features as possible into Qt, and only keep the stuff that isn't accepted in our \
> libraries.
> But here, I am not really sure. Is the alignment requirement specific to KDE's \
> guidelines?
Reading the comments in \
http://agateau.com/2011/clean-up-your-layouts-with-columnresizer/ there seems to be \
quite a lot of interest in this, some also saying it should be in Qt.
- Dominik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118514/#review59170
-----------------------------------------------------------
On June 4, 2014, 9:52 a.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118514/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 9:52 a.m.)
>
>
> Review request for KDE Frameworks and Christoph Feck.
>
>
> Repository: kwidgetsaddons
>
>
> Description
> -------
>
> I have been asked to add ColumnResizer to KWidgetAddons. ColumnResizer is a helper \
> class I created long ago to help maintain uniform widths across layouts. You can \
> learn more about it from the blog post I wrote back then: \
> http://agateau.com/2011/clean-up-your-layouts-with-columnresizer/ . I simplified \
> the API a bit, added some documentation, and here it is.
>
> Diffs
> -----
>
> src/CMakeLists.txt 27b9084
> src/kcolumnresizer.h PRE-CREATION
> src/kcolumnresizer.cpp PRE-CREATION
> tests/CMakeLists.txt eccf887
> tests/kcolumnresizertest.h PRE-CREATION
> tests/kcolumnresizertest.cpp PRE-CREATION
> tests/kcolumnresizertest.ui PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/118514/diff/
>
>
> Testing
> -------
>
> Manual test program behaves as expected.
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118514/">https://git.reviewboard.kde.org/r/118514/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 4th, 2014, 11:41 a.m. UTC, <b>Dominik \
Haumann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">What about adding something like this to Qt ?</pre> </blockquote>
<p>On June 4th, 2014, 11:57 a.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First, I was thinking \
the same. The efforts with KF5 work was to get as much features as possible into Qt, \
and only keep the stuff that isn't accepted in our libraries.
But here, I am not really sure. Is the alignment requirement specific to KDE's \
guidelines?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Reading the comments in \
http://agateau.com/2011/clean-up-your-layouts-with-columnresizer/ there seems to be \
quite a lot of interest in this, some also saying it should be in Qt.</pre> <br />
<p>- Dominik</p>
<br />
<p>On June 4th, 2014, 9:52 a.m. UTC, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated June 4, 2014, 9:52 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have been asked to add ColumnResizer to KWidgetAddons. ColumnResizer \
is a helper class I created long ago to help maintain uniform widths across layouts. \
You can learn more about it from the blog post I wrote back then: \
http://agateau.com/2011/clean-up-your-layouts-with-columnresizer/ . I simplified the \
API a bit, added some documentation, and here it is.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual test program behaves as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(27b9084)</span></li>
<li>src/kcolumnresizer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcolumnresizer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(eccf887)</span></li>
<li>tests/kcolumnresizertest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kcolumnresizertest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/kcolumnresizertest.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118514/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic