[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.
From: "Alex Merry" <alex.merry () kde ! org>
Date: 2014-05-29 15:11:26
Message-ID: 20140529151126.2659.21142 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 29, 2014, 3:02 p.m., Alex Merry wrote:
> > Did you try compiling this? Because that macro doesn't exist any more - there is \
> > an ecm_optional_add_subdirectory() in ECM if you \
> > include(ECMOptionalAddSubdirectory), though.
> > However, I think an explicit option(), with a useful help-text, would be better.
Ah, seeing David's comment made me realise I hadn't clocked the branch (I generally \
assume anything the kdeframeworks group has been added to is a frameworks branch). \
Although my point still stands about using option() to get a more useful help-text.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118340/#review58733
-----------------------------------------------------------
On May 27, 2014, 5:27 a.m., Matthew Dawson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118340/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 5:27 a.m.)
>
>
> Review request for KDE Frameworks, Plasma and Ivan Čukić.
>
>
> Repository: kactivities
>
>
> Description
> -------
>
> To allow for the library to be co-installed with the frameworks version, allow the \
> daemon to be disabled.
> I'm not sure if this is the best way to do this. If there is any better way, I'll \
> update the patch as appropriate.
>
> Diffs
> -----
>
> src/CMakeLists.txt b4733648fd53ebd681694f185cc5b23f51dfd3f9
>
> Diff: https://git.reviewboard.kde.org/r/118340/diff/
>
>
> Testing
> -------
>
> Visually inspected install directories. Seems to remove only what is necessary.
>
>
> Thanks,
>
> Matthew Dawson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118340/">https://git.reviewboard.kde.org/r/118340/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 29th, 2014, 3:02 p.m. UTC, <b>Alex \
Merry</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Did you try compiling this? Because that macro doesn't exist any \
more - there is an ecm_optional_add_subdirectory() in ECM if you \
include(ECMOptionalAddSubdirectory), though.
However, I think an explicit option(), with a useful help-text, would be \
better.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, seeing David's \
comment made me realise I hadn't clocked the branch (I generally assume anything \
the kdeframeworks group has been added to is a frameworks branch). Although my point \
still stands about using option() to get a more useful help-text.</pre> <br />
<p>- Alex</p>
<br />
<p>On May 27th, 2014, 5:27 a.m. UTC, Matthew Dawson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma and Ivan Čukić.</div>
<div>By Matthew Dawson.</div>
<p style="color: grey;"><i>Updated May 27, 2014, 5:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kactivities
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To allow for the library to be co-installed with the frameworks version, \
allow the daemon to be disabled.
I'm not sure if this is the best way to do this. If there is any better way, \
I'll update the patch as appropriate.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Visually inspected install directories. Seems to remove only what is \
necessary.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: \
grey">(b4733648fd53ebd681694f185cc5b23f51dfd3f9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118340/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic