'Re: Review Request 118389: Fix Compile for kio/src/core/udsentry.cpp on Mac'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 118389: Fix Compile for kio/src/core/udsentry.cpp on Mac
From:       "Allen Winter" <winter () kde ! org>
Date:       2014-05-29 14:38:02
Message-ID: 20140529143802.2659.72799 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118389/
-----------------------------------------------------------

(Updated May 29, 2014, 2:38 p.m.)

Status
------

This change has been discarded.

Review request for KDE Frameworks, David Faure and Mark Gaiser.

Repository: kio

Description
-------

This patch fixes the compile for kio/src/core/udsentry.cpp on Mac, where the stat \
structure has the st_mtimespec member instead of st_mtim (and st_atimespec instead of \
st_atim). We use CMake to set the HAVE_STAT_ST_MTIMESPEC macro, which gets defined \
(or not) in config-kiocore.h

it also uses st_atimespec (or st_atim) values for setting the USD_ACCESS_TIME. Mark \
verified this already.

Diffs
-----

  src/core/ConfigureChecks.cmake 472f65f 
  src/core/config-kiocore.h.cmake 6041c9d 
  src/core/udsentry.cpp 6ec8e11 

Diff: https://git.reviewboard.kde.org/r/118389/diff/

Testing
-------

Still compiles on Linux.  Compiles ok on Mac.

Thanks,

Allen Winter

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118389/">https://git.reviewboard.kde.org/r/118389/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks, David Faure and Mark Gaiser.</div>
<div>By Allen Winter.</div>

<p style="color: grey;"><i>Updated May 29, 2014, 2:38 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes the compile for kio/src/core/udsentry.cpp on Mac, where \
the stat structure has the st_mtimespec member instead of st_mtim (and st_atimespec \
instead of st_atim). We use CMake to set the HAVE_STAT_ST_MTIMESPEC macro, which gets \
defined (or not) in config-kiocore.h

it also uses st_atimespec (or st_atim) values for setting the USD_ACCESS_TIME. Mark \
verified this already. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Still compiles on Linux.  Compiles ok on Mac.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/ConfigureChecks.cmake <span style="color: grey">(472f65f)</span></li>

 <li>src/core/config-kiocore.h.cmake <span style="color: grey">(6041c9d)</span></li>

 <li>src/core/udsentry.cpp <span style="color: grey">(6ec8e11)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118389/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 