[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 118366: Porting keyboard module to Framework5
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-05-28 6:10:11
Message-ID: 20140528061011.27790.75917 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118366/#review58618
-----------------------------------------------------------
kcms/keyboard/flags.cpp
<https://git.reviewboard.kde.org/r/118366/#comment40807>
why not removed?
kcms/keyboard/kcm_keyboard.ui
<https://git.reviewboard.kde.org/r/118366/#comment40808>
the rename looks unrelated
kcms/keyboard/kcmmisc.cpp
<https://git.reviewboard.kde.org/r/118366/#comment40809>
coding style: whitespace after for and in front of {
kcms/keyboard/kcmmisc.cpp
<https://git.reviewboard.kde.org/r/118366/#comment40810>
for new connects I would use the new compile time checked syntax.
kcms/keyboard/kcmmisc.cpp
<https://git.reviewboard.kde.org/r/118366/#comment40811>
why this commented debug statement?
kcms/keyboard/keyboard_config.cpp
<https://git.reviewboard.kde.org/r/118366/#comment40812>
remove?
kcms/keyboard/layouts_menu.cpp
<https://git.reviewboard.kde.org/r/118366/#comment40813>
remove?
kcms/keyboard/xinput_helper.h
<https://git.reviewboard.kde.org/r/118366/#comment40814>
I think it would have been better to keep the parent argument and pass it to the base QObject
kcms/keyboard/xinput_helper.cpp
<https://git.reviewboard.kde.org/r/118366/#comment40815>
removing the event doesn't remove the fact that this method is not yet ported. See the #if 0 which \
indicates that this code has not been adjusted to xcb yet.
- Martin Gräßlin
On May 27, 2014, 11:02 p.m., shivam makkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118366/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 11:02 p.m.)
>
>
> Review request for kde-workspace, KDE Frameworks and Andriy Rysin.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Removed deprecated statements and ported keyboard module to framework 5.
>
>
> Diffs
> -----
>
> kcms/keyboard/bindings.cpp 21541e0
> kcms/keyboard/flags.cpp b768586
> kcms/keyboard/kcm_keyboard.ui 0062d1c
> kcms/keyboard/kcm_keyboard_widget.cpp 21685eb
> kcms/keyboard/kcmmisc.h 411bdd2
> kcms/keyboard/kcmmisc.cpp 6f787ea
> kcms/keyboard/kcmmiscwidget.ui 37fbaf4
> kcms/keyboard/keyboard_config.cpp f3ff97c
> kcms/keyboard/keyboard_daemon.cpp 25673b0
> kcms/keyboard/keyboard_hardware.cpp dca49b6
> kcms/keyboard/layout_memory.cpp 9e72361
> kcms/keyboard/layout_memory_persister.cpp 8a6118a
> kcms/keyboard/layouts_menu.cpp fd436c4
> kcms/keyboard/xinput_helper.h 343d7ed
> kcms/keyboard/xinput_helper.cpp b311579
>
> Diff: https://git.reviewboard.kde.org/r/118366/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shivam makkar
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118366/">https://git.reviewboard.kde.org/r/118366/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118366/diff/2/?file=275626#file275626line21" style="color: black; \
font-weight: bold; text-decoration: underline;">kcms/keyboard/flags.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">21</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "><span class="cp">#include <kdebug.h></span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">21</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "><span class="c1"><span class="hl">//</span>#include <kdebug.h></span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">why not removed?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118366/diff/2/?file=275627#file275627line335" style="color: \
black; font-weight: bold; text-decoration: underline;">kcms/keyboard/kcm_keyboard.ui</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">335</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <widget class="QPushButton" name="preview<span \
class="hl">b</span>utton"></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">335</font></th> <td \
bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<widget class="QPushButton" name="preview<span \
class="hl">B</span>utton"></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">the rename looks unrelated</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118366/diff/2/?file=275630#file275630line68" style="color: black; \
font-weight: bold; text-decoration: underline;">kcms/keyboard/kcmmisc.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">66</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">ui</span><span \
class="p">.</span><span class="n">keyboardRepeatButtonGroup</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span class="n">changed</span><span \
class="p">(</span><span class="kt">int</span><span class="p">)),</span> <span class="k">this</span><span \
class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span \
class="n">keyboardRepeatStateChanged</span><span class="p">(</span><span class="kt">int</span><span \
class="p">)));</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; \
border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">for</span><span \
class="p">(</span><span class="kt">int</span> <span class="n">i</span> <span class="o">=</span> <span \
class="mi">0</span><span class="p">;</span> <span class="n">i</span> <span class="o"><</span> <span \
class="n">btns</span><span class="p">.</span><span class="n">size</span><span class="p">();</span> <span \
class="n">i</span><span class="o">++</span><span class="p">){</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">coding style: whitespace after for and in front of \
{</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118366/diff/2/?file=275630#file275630line77" style="color: black; \
font-weight: bold; text-decoration: underline;">kcms/keyboard/kcmmisc.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">77</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span \
class="p">(</span><span class="n">ui</span><span class="p">.</span><span \
class="n">kbRepButtonGroup</span><span class="p">,</span> <span class="n">SIGNAL</span><span \
class="p">(</span><span class="n">buttonClicked</span><span class="p">(</span><span \
class="kt">int</span><span class="p">)),</span> <span class="k">this</span><span class="p">,</span> <span \
class="n">SLOT</span><span class="p">(</span><span class="n">changed</span><span \
class="p">()));</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">78</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span \
class="p">(</span><span class="n">ui</span><span class="p">.</span><span \
class="n">kbRepButtonGroup</span><span class="p">,</span> <span class="n">SIGNAL</span><span \
class="p">(</span><span class="n">buttonClicked</span><span class="p">(</span><span \
class="kt">int</span><span class="p">)),</span> <span class="k">this</span><span class="p">,</span> <span \
class="n">SLOT</span><span class="p">(</span><span class="n">keyboardRepeatStateChanged</span><span \
class="p">(</span><span class="kt">int</span><span class="p">)));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">for new connects I would use the new compile time \
checked syntax.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118366/diff/2/?file=275630#file275630line187" style="color: \
black; font-weight: bold; text-decoration: underline;">kcms/keyboard/kcmmisc.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KCMiscKeyboardWidget::load()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">187</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//qDebug()<<"kb: \
"<<keyboardRepeat<<" nmlck: "<<numlockState;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">why this commented debug statement?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118366/diff/2/?file=275632#file275632line23" style="color: black; \
font-weight: bold; text-decoration: underline;">kcms/keyboard/keyboard_config.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">23</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "><span class="cp">#include <kdebug.h></span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">23</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "><span class="c1"><span class="hl">//</span>#include <kdebug.h></span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">remove?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118366/diff/2/?file=275637#file275637line21" style="color: black; \
font-weight: bold; text-decoration: underline;">kcms/keyboard/layouts_menu.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">21</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "><span class="cp">#include <kmenu.h></span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">21</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "><span class="c1"><span class="hl">//</span>#include <kmenu.h></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">remove?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118366/diff/2/?file=275638#file275638line32" style="color: black; \
font-weight: bold; text-decoration: underline;">kcms/keyboard/xinput_helper.h</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">32</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "><span class="tb"> </span><span class="n">XInputEventNotifier</span><span \
class="p">(</span><span class="n">QWidget</span><span class="o">*</span> <span class="n"><span \
class="hl">parent</span></span><span class="o"><span class="hl">=</span></span><span \
class="nb">NULL</span><span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">32</font></th> <td \
bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">XInputEventNotifier</span><span class="p">(</span><span class="n">QWidget</span><span \
class="o">*</span> <span class="o"><span class="hl">=</span></span><span class="hl"> </span><span \
class="nb">NULL</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">I think it would have been better to keep the parent \
argument and pass it to the base QObject</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118366/diff/2/?file=275639#file275639line95" style="color: black; \
font-weight: bold; text-decoration: underline;">kcms/keyboard/xinput_helper.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static bool \
isRealKeyboard(const char* deviceName)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">95</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "><span class="kt">int</span> <span class="n">XInputEventNotifier</span><span \
class="o">::</span><span class="n">getNewDeviceEventType</span><span class="p">(</span><span \
class="kt">xcb_generic_event_t</span><span class="o">*</span> <span class="n">event</span><span \
class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: \
1px solid #C0C0C0;" align="right"><font size="2">95</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">int</span> <span \
class="n">XInputEventNotifier</span><span class="o">::</span><span \
class="n">getNewDeviceEventType</span><span class="p">(</span><span \
class="kt">xcb_generic_event_t</span><span class="o">*</span> <span class="cm"><span \
class="hl">/*</span>event<span class="hl">*/</span></span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">removing the event doesn't remove the fact that \
this method is not yet ported. See the #if 0 which indicates that this code has not been adjusted to xcb \
yet.</pre> </div>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On May 27th, 2014, 11:02 p.m. CEST, shivam makkar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kde-workspace, KDE Frameworks and Andriy Rysin.</div>
<div>By shivam makkar.</div>
<p style="color: grey;"><i>Updated May 27, 2014, 11:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed deprecated statements and ported \
keyboard module to framework 5.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/keyboard/bindings.cpp <span style="color: grey">(21541e0)</span></li>
<li>kcms/keyboard/flags.cpp <span style="color: grey">(b768586)</span></li>
<li>kcms/keyboard/kcm_keyboard.ui <span style="color: grey">(0062d1c)</span></li>
<li>kcms/keyboard/kcm_keyboard_widget.cpp <span style="color: grey">(21685eb)</span></li>
<li>kcms/keyboard/kcmmisc.h <span style="color: grey">(411bdd2)</span></li>
<li>kcms/keyboard/kcmmisc.cpp <span style="color: grey">(6f787ea)</span></li>
<li>kcms/keyboard/kcmmiscwidget.ui <span style="color: grey">(37fbaf4)</span></li>
<li>kcms/keyboard/keyboard_config.cpp <span style="color: grey">(f3ff97c)</span></li>
<li>kcms/keyboard/keyboard_daemon.cpp <span style="color: grey">(25673b0)</span></li>
<li>kcms/keyboard/keyboard_hardware.cpp <span style="color: grey">(dca49b6)</span></li>
<li>kcms/keyboard/layout_memory.cpp <span style="color: grey">(9e72361)</span></li>
<li>kcms/keyboard/layout_memory_persister.cpp <span style="color: grey">(8a6118a)</span></li>
<li>kcms/keyboard/layouts_menu.cpp <span style="color: grey">(fd436c4)</span></li>
<li>kcms/keyboard/xinput_helper.h <span style="color: grey">(343d7ed)</span></li>
<li>kcms/keyboard/xinput_helper.cpp <span style="color: grey">(b311579)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118366/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic