[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 118332: Update usage of QVariant::type() for Qt5.
From: "Thomas Braxton" <kde.braxton () gmail ! com>
Date: 2014-05-26 19:59:37
Message-ID: 20140526195937.2533.72273 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118332/
-----------------------------------------------------------
(Updated May 26, 2014, 7:59 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Matthew Dawson.
Repository: kconfig
Description
-------
According to http://qt-project.org/doc/qt-5/qvariant.html#type the
return value of QVariant::type() should be interpreted as a
QMetaType::Type.
This also silences the compile-time warnings about 38 not being a member
of QVariant::Type.
Diffs
-----
src/core/kconfiggroup.cpp bce9e69d518ce987c4cfaf0f9dd8a2d1cbac6f5b
Diff: https://git.reviewboard.kde.org/r/118332/diff/
Testing
-------
All tests still pass.
Thanks,
Thomas Braxton
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118332/">https://git.reviewboard.kde.org/r/118332/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Matthew Dawson.</div>
<div>By Thomas Braxton.</div>
<p style="color: grey;"><i>Updated May 26, 2014, 7:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">According to http://qt-project.org/doc/qt-5/qvariant.html#type the \
return value of QVariant::type() should be interpreted as a QMetaType::Type.
This also silences the compile-time warnings about 38 not being a member
of QVariant::Type.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All tests still pass.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/kconfiggroup.cpp <span style="color: \
grey">(bce9e69d518ce987c4cfaf0f9dd8a2d1cbac6f5b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118332/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic