'Re: Review Request 118216: Skip non-directory files inside the po/ directory'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 118216: Skip non-directory files inside the po/ directory
From:       "Alex Merry" <alex.merry () kde ! org>
Date:       2014-05-20 14:15:39
Message-ID: 20140520141539.16632.47778 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118216/#review58198
-----------------------------------------------------------

Perhaps put some files in the test directories to make sure they are ignored?

- Alex Merry

On May 20, 2014, 1:05 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118216/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 1:05 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> I had a build failure today because I generated the catalog template (.pot file) in \
> the kwidgetsaddons repository and so had a po/kwidgetsaddons_qt5.pot file. Build \
> failed because it tried to find .po files in "po/kwidgetsaddons_qt5.pot/" 
> 
> Diffs
> -----
> 
> modules/ECMPoQmTools.cmake e217dd3 
> tests/ECMPoQmToolsTest/CMakeLists.txt 3dcb351 
> 
> Diff: https://git.reviewboard.kde.org/r/118216/diff/
> 
> 
> Testing
> -------
> 
> kwidgetsaddons now build even if I have a .pot file in there. Added a file to be \
> ignored to the po/ dir of the unit test. 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118216/">https://git.reviewboard.kde.org/r/118216/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Perhaps put some files \
in the test directories to make sure they are ignored?</pre>  <br />

<p>- Alex Merry</p>

<br />
<p>On May 20th, 2014, 1:05 p.m. UTC, Aurélien Gâteau wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Build System, Extra Cmake Modules and KDE Frameworks.</div>
<div>By Aurélien Gâteau.</div>

<p style="color: grey;"><i>Updated May 20, 2014, 1:05 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I had a build failure today because I generated the catalog template \
(.pot file) in the kwidgetsaddons repository and so had a po/kwidgetsaddons_qt5.pot \
file. Build failed because it tried to find .po files in \
&quot;po/kwidgetsaddons_qt5.pot/&quot;</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kwidgetsaddons now build even if I have a .pot file in there. Added a \
file to be ignored to the po/ dir of the unit test.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>modules/ECMPoQmTools.cmake <span style="color: grey">(e217dd3)</span></li>

 <li>tests/ECMPoQmToolsTest/CMakeLists.txt <span style="color: \
grey">(3dcb351)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118216/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 