[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 117695: change where dynamic replace tabs is performed
From: "Commit Hook" <null () kde ! org>
Date: 2014-05-19 22:36:32
Message-ID: 20140519223632.16632.56287 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117695/#review58180
-----------------------------------------------------------
This review has been submitted with commit f9d33a959dd03cd4f335532942e910119b44c8d6 \
by Sven Brauch to branch master.
- Commit Hook
On May 3, 2014, 12:57 a.m., Sven Brauch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117695/
> -----------------------------------------------------------
>
> (Updated May 3, 2014, 12:57 a.m.)
>
>
> Review request for KDE Frameworks and Christoph Cullmann.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> This makes typeChars handle replacing tabs by spaces, instead of insertText. The \
> rationale is that insertText is often called programatically, and the caller should \
> be able to rely on the text he requests to be inserted is actually inserted, and \
> not changed on-the-fly. Examples for where the previous solution caused problems \
> are KDevelop (the codegen) and kte-collaborative.
> I'm not sure what the code I removed was doing (heh). It looks like it is supposed \
> to advance to the next indent level if the current indent level is odd, but that \
> still works after removing it.
> The obvious user-visible change here is that tabs in pasted text will no longer be \
> replaced. But since I always found this behaviour undesirable anyways, I did not \
> bother to replicate it. I will instead wait for people to yell at me for removing \
> it. ;)
>
> Diffs
> -----
>
> autotests/src/katedocument_test.h cff61d0
> autotests/src/katedocument_test.cpp f3eef18
> src/document/katedocument.h 83cc031
> src/document/katedocument.cpp 546d3e6
>
> Diff: https://git.reviewboard.kde.org/r/117695/diff/
>
>
> Testing
> -------
>
> Just some quick manual tests, it seems to still work as intended.
>
>
> Thanks,
>
> Sven Brauch
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117695/">https://git.reviewboard.kde.org/r/117695/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit f9d33a959dd03cd4f335532942e910119b44c8d6 by Sven Brauch to \
branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On May 3rd, 2014, 12:57 a.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Christoph Cullmann.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated May 3, 2014, 12:57 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This makes typeChars handle replacing tabs by spaces, instead of \
insertText. The rationale is that insertText is often called programatically, and the \
caller should be able to rely on the text he requests to be inserted is actually \
inserted, and not changed on-the-fly. Examples for where the previous solution caused \
problems are KDevelop (the codegen) and kte-collaborative.
I'm not sure what the code I removed was doing (heh). It looks like it is \
supposed to advance to the next indent level if the current indent level is odd, but \
that still works after removing it.
The obvious user-visible change here is that tabs in pasted text will no longer be \
replaced. But since I always found this behaviour undesirable anyways, I did not \
bother to replicate it. I will instead wait for people to yell at me for removing it. \
;)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Just some quick manual tests, it seems to still work as intended.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/src/katedocument_test.h <span style="color: \
grey">(cff61d0)</span></li>
<li>autotests/src/katedocument_test.cpp <span style="color: \
grey">(f3eef18)</span></li>
<li>src/document/katedocument.h <span style="color: grey">(83cc031)</span></li>
<li>src/document/katedocument.cpp <span style="color: grey">(546d3e6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117695/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic