[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 117682: Define _DARWIN_C_SOURCE when building on Mac
From: "Commit Hook" <null () kde ! org>
Date: 2014-05-04 16:46:06
Message-ID: 20140504164606.20770.62220 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117682/#review57258
-----------------------------------------------------------
This review has been submitted with commit ea75468cd820d17317ef2278ebebe3ca1b61d936 \
by Allen Winter to branch master.
- Commit Hook
On April 22, 2014, 11:51 p.m., Allen Winter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117682/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 11:51 p.m.)
>
>
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Harald \
> Fernengel.
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Must define _DARWIN_C_SOURCE on the Mac in order to get the declarations for \
> readlink(), setegid(), seteuid(), etc i.e for Single Unix Standard v3 (SUSv3) \
> conformance
>
> Diffs
> -----
>
> kde-modules/KDECompilerSettings.cmake 229e4f5
>
> Diff: https://git.reviewboard.kde.org/r/117682/diff/
>
>
> Testing
> -------
>
> works on the Mac
> didn't break the build on Linux
>
>
> Thanks,
>
> Allen Winter
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117682/">https://git.reviewboard.kde.org/r/117682/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit ea75468cd820d17317ef2278ebebe3ca1b61d936 by Allen Winter to \
branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On April 22nd, 2014, 11:51 p.m. UTC, Allen Winter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Harald \
Fernengel.</div> <div>By Allen Winter.</div>
<p style="color: grey;"><i>Updated April 22, 2014, 11:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Must define _DARWIN_C_SOURCE on the Mac in order to get the declarations \
for readlink(), setegid(), seteuid(), etc i.e for Single Unix Standard v3 (SUSv3) \
conformance </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works on the Mac didn't break the build on Linux</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDECompilerSettings.cmake <span style="color: \
grey">(229e4f5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117682/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic