From kde-frameworks-devel  Tue Apr 29 22:41:01 2014
From: =?ISO-8859-1?Q?=C0lex?= Fiestas <afiestas () kde ! org>
Date: Tue, 29 Apr 2014 22:41:01 +0000
To: kde-frameworks-devel
Subject: Re: visibility compile flag
Message-Id: <4084242.7qzevbGKUN () minibad>
X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=139881127208563

On Tuesday 29 April 2014 09:21:44 Kevin Ottens wrote:
> Hello,
> =

> On Monday 28 April 2014 19:50:51 =C0lex Fiestas wrote:
> > I'm porting libkscreen to Frameworks and I found that we are passing (w=
hen
> > available) -fvisibility=3Dhidden.
> > =

> > After reading this[1] really quick I thought I would send an email here=
 so
> > people wiser than me can decide if it makes sense to enable it to all
> > frameworks by default, it sounds useful.
> =

> I'm confused... isn't it already the case?
> =

> At least KDECompilerSettings.cmake has the following line:
> set(CMAKE_CXX_VISIBILITY_PRESET hidden)
> =

> It should enable -fvisibility=3Dhidden for all frameworks as they include=
 that
> file.
> =

> Or you meant something else?

O I did check but apparently not enough :/

Nothing then! (more code that I can remove from kscreen cmake :p)

Cheers.
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel