[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: libkomparediff2
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2014-04-27 10:42:43
Message-ID: CACcA1RqMiqc76ph8ff+oSUkJE1e3PqS5oZs9FkCnNrfNfUZo+w () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sat, Apr 26, 2014 at 6:07 AM, Jeremy Whiting <jpwhiting@kde.org> wrote:

> Hello,
>
> I've prepared a port of libkomparediff2 to KDE Frameworks and Qt 5.2
> on the frameworks branch of it's git repo. If someone would take a
> look and check if I did anything wrong that would be great.  It builds
> here and the tests all pass, but a second (or more) set of eyes is
> always welcome.
>
> I guess another step to take with it would be to port it away from
> KDELibs4Support and KIO::NetAccess ?
>
> Any comments welcome, thanks,
> Jeremy
> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>

Hi Jeremy!
I just built it, it's indeed looking good.

I just committed a couple of changes because it was not setting the
library's name properly, but it's a small detail.

Cheers!
Aleix

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sat, Apr 26, 2014 \
at 6:07 AM, Jeremy Whiting <span dir="ltr">&lt;<a href="mailto:jpwhiting@kde.org" \
target="_blank">jpwhiting@kde.org</a>&gt;</span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hello,<br> <br>
I&#39;ve prepared a port of libkomparediff2 to KDE Frameworks and Qt 5.2<br>
on the frameworks branch of it&#39;s git repo. If someone would take a<br>
look and check if I did anything wrong that would be great.   It builds<br>
here and the tests all pass, but a second (or more) set of eyes is<br>
always welcome.<br>
<br>
I guess another step to take with it would be to port it away from<br>
KDELibs4Support and KIO::NetAccess ?<br>
<br>
Any comments welcome, thanks,<br>
Jeremy<br>
_______________________________________________<br>
Kde-frameworks-devel mailing list<br>
<a href="mailto:Kde-frameworks-devel@kde.org">Kde-frameworks-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-frameworks-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/kde-frameworks-devel</a><br> \
</blockquote></div><br></div><div class="gmail_extra">Hi Jeremy!</div><div \
class="gmail_extra">I just built it, it&#39;s indeed looking good.</div><div \
class="gmail_extra"><br></div><div class="gmail_extra">I just committed a couple of \
changes because it was not setting the library&#39;s name properly, but it&#39;s a \
small detail.</div>

<div class="gmail_extra"><br></div><div class="gmail_extra">Cheers!</div><div \
class="gmail_extra">Aleix</div></div>



_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


[prev in list] [next in list] [prev in thread] [next in thread]