[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 117795: Adapt to yaml file renaming ($framework.yaml => metainfo.yaml)
From: "Commit Hook" <null () kde ! org>
Date: 2014-04-27 9:51:22
Message-ID: 20140427095122.9428.19046 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117795/#review56670
-----------------------------------------------------------
This review has been submitted with commit 8ea94caa0ad7efc94d6aea3688af3b40ae99ea86 \
by Aurélien Gâteau to branch master.
- Commit Hook
On April 27, 2014, 9:40 a.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117795/
> -----------------------------------------------------------
>
> (Updated April 27, 2014, 9:40 a.m.)
>
>
> Review request for KDE Frameworks and Aurélien Gâteau.
>
>
> Repository: kapidox
>
>
> Description
> -------
>
> The dependency diagram code used to extract the framework name from the name of the \
> yaml file, but that is not possible anymore. We can't use the name of the directory \
> containing the code because build.kde.org stores the framework code under different \
> names. Therefore I decided to use the name of the project() from the toplevel \
> CMakeLists.txt. I rewrote parse_fancyname() to get the info from the CMakeLists.txt \
> instead of README.md for consistency.
> That patch is unfortunately quite large as the changes cascaded quite a lot.
>
>
> Diffs
> -----
>
> src/kgenapidox 8fbffb1
> src/kapidox/data/dependencies.md.mustache 5d34042
> src/kapidox/__init__.py 61e6a13
> src/depdiagram-prepare 320502f
> src/kgenframeworksapidox 101f9b3
>
> Diff: https://git.reviewboard.kde.org/r/117795/diff/
>
>
> Testing
> -------
>
> - Regenerated all the diagrams.
> - Ran kgenframeworksapidox on all the frameworks.
> - Ran kgenapidox on one framework.
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117795/">https://git.reviewboard.kde.org/r/117795/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 8ea94caa0ad7efc94d6aea3688af3b40ae99ea86 by Aurélien Gâteau \
to branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On April 27th, 2014, 9:40 a.m. UTC, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Aurélien Gâteau.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated April 27, 2014, 9:40 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kapidox
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The dependency diagram code used to extract the framework name from the \
name of the yaml file, but that is not possible anymore. We can't use the name of \
the directory containing the code because build.kde.org stores the framework code \
under different names. Therefore I decided to use the name of the project() from the \
toplevel CMakeLists.txt. I rewrote parse_fancyname() to get the info from the \
CMakeLists.txt instead of README.md for consistency.
That patch is unfortunately quite large as the changes cascaded quite a lot.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Regenerated all the diagrams.
- Ran kgenframeworksapidox on all the frameworks.
- Ran kgenapidox on one framework.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kgenapidox <span style="color: grey">(8fbffb1)</span></li>
<li>src/kapidox/data/dependencies.md.mustache <span style="color: \
grey">(5d34042)</span></li>
<li>src/kapidox/__init__.py <span style="color: grey">(61e6a13)</span></li>
<li>src/depdiagram-prepare <span style="color: grey">(320502f)</span></li>
<li>src/kgenframeworksapidox <span style="color: grey">(101f9b3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117795/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic