--===============5755701426347550719== Content-Type: multipart/alternative; boundary="===============8674152244902253140==" --===============8674152244902253140== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ ----------------------------------------------------------- (Updated April 23, 2014, 9:09 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kservice Description ------- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error. Diffs ----- src/plugin/kdbusservicestarter.cpp 6f011bd Diff: https://git.reviewboard.kde.org/r/117604/diff/ Testing ------- Tested for review 116951. Thanks, David Jarvie --===============8674152244902253140== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/

This change has been marked as submitted.

Review request for KDE Frameworks and David Faure.

By David Jarvie.

Updated April 23, 2014, 9:09 p.m.

Repository: kservice

Description

When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox.

This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error.

Testing

Tested for review 116951.

Diffs

src/plugin/kdbusservicestarter.cpp (6f011bd)

View Diff

--===============8674152244902253140==-- --===============5755701426347550719== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============5755701426347550719==--