[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string
From: "David Faure" <faure () kde ! org>
Date: 2014-04-23 5:47:54
Message-ID: 20140423054754.6431.52249 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117604/#review56243
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On April 22, 2014, 10:03 p.m., David Jarvie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117604/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 10:03 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> When KDBusServiceStarter::findServiceFor() fails to start the requested service \
> after it is found to not be running, it does not return the error string. This \
> patch fixes that and makes it behave as in the apidox.
> This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that \
> the qDebug line has been uncommented on the grounds that it reports an error.
>
> Diffs
> -----
>
> src/plugin/kdbusservicestarter.cpp 6f011bd
>
> Diff: https://git.reviewboard.kde.org/r/117604/diff/
>
>
> Testing
> -------
>
> Tested for review 116951.
>
>
> Thanks,
>
> David Jarvie
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117604/">https://git.reviewboard.kde.org/r/117604/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- David Faure</p>
<br />
<p>On April 22nd, 2014, 10:03 p.m. UTC, David Jarvie wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By David Jarvie.</div>
<p style="color: grey;"><i>Updated April 22, 2014, 10:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When KDBusServiceStarter::findServiceFor() fails to start the requested \
service after it is found to not be running, it does not return the error string. \
This patch fixes that and makes it behave as in the apidox.
This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that \
the qDebug line has been uncommented on the grounds that it reports an error.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested for review 116951.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugin/kdbusservicestarter.cpp <span style="color: \
grey">(6f011bd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117604/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic