[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: kcoreaddons5 extraction
From:       Alexander Potashev <aspotashev () gmail ! com>
Date:       2014-03-29 0:32:49
Message-ID: CADMG6+8L9A3Zm8tqi5bgowOEohnyu=V9-YB_GWWwmr6qg=xh3w () mail ! gmail ! com
[Download RAW message or body]

2014-03-28 22:15 GMT+04:00 Luigi Toscano <luigi.toscano@tiscali.it>:
> On Friday 28 of March 2014 19:28:16 Yuri Chornoivan wrote:
>> Hi,
>>
>> https://projects.kde.org/projects/frameworks/kcoreaddons/repository/revision
>> s/master/entry/src/lib/kaboutdata.cpp#L258
>>
>> licenseShort = QCoreApplication::translate("KAboutLicense", "@item license
>> (short name)", "GPL v2");
>>
>> is extracted as (the same thing for the others)
>>
>> #:
>> ../../home/scripty/prod/git-unstable/frameworks_kcoreaddons/src/lib/kaboutda
>> ta.cpp:258 msgctxt "KAboutLicense|GPL v2"
>> msgid "@item license (short name)"
>> msgstr ""
>>
>> So what is wrong? Extraction script or the order of parameters for all
>> licenses?

Hello,

I didn't play with Qt i18n API much, but in this case it's clear from
the Qt docs [1] that the order of parameters in the code is wrong. The
source text (e.g. "GPL v2") is should be passed as the second
parameter, msgctxt "@item license (short name)" being the third one.

[1] http://qt-project.org/doc/qt-5.0/qtcore/qcoreapplication.html#translate

-- 
Alexander Potashev
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]