[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
From: "Stephen Kelly" <steveire () gmail ! com>
Date: 2014-03-12 18:16:08
Message-ID: 20140312181608.18225.64621 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 4, 2014, 8:45 p.m., Kevin Ottens wrote:
> > And I agree with Aurélien, a bug should be filed and Stephen involved in that \
> > issue.
>
> Stephen Kelly wrote:
> Please provide a minimal testcase. The feature is unit tested in cmake. If it's \
> broken, it needs to be fixed soon (before the final 3.0 release).
> Alexander Richardson wrote:
> I'll try to reproduce it with a minimal test case, however I am away until Sunday, \
> so it will be a while.
> Stephen Kelly wrote:
> I've pushed a fix to the cmake next branch. Please test it instead of committing \
> this patch.
> Another point of note is that you shouldn't read the LOCATION property from the \
> target. You get a policy warning about that. Use the target name directly instead.
> Alexander Richardson wrote:
> I can confirm that using cmake next branch fixes the issue.
> How do I check that the currently used CMake version contains that fix?
>
> Kevin Ottens wrote:
> No idea, anyone?
Maybe you want 'NOT VERSION_LESS 3.0'.
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115918/#review51946
-----------------------------------------------------------
On March 4, 2014, 8:45 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115918/
> -----------------------------------------------------------
>
> (Updated March 4, 2014, 8:45 p.m.)
>
>
> Review request for KDE Frameworks and Stephen Kelly.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> Fix kservice_desktop_to_json for Visual Studio
>
> The CMake generator for Visual Studio cannot handle the new build-time
> kservice_desktop_to_json macro -> fall back to configure-time generation
>
>
> Diffs
> -----
>
> KF5ServiceMacros.cmake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3
>
> Diff: https://git.reviewboard.kde.org/r/115918/diff/
>
>
> Testing
> -------
>
> ktexteditor fails to build before this patch (because moc can't find the .json \
> file), with the patch it compiles
>
> Thanks,
>
> Alexander Richardson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115918/">https://git.reviewboard.kde.org/r/115918/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 4th, 2014, 8:45 p.m. UTC, <b>Kevin \
Ottens</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">And I agree with Aurélien, a bug should be filed and Stephen involved \
in that issue.</pre> </blockquote>
<p>On March 5th, 2014, 8:48 a.m. UTC, <b>Stephen Kelly</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please provide a minimal \
testcase. The feature is unit tested in cmake. If it's broken, it needs to be \
fixed soon (before the final 3.0 release).</pre> </blockquote>
<p>On March 5th, 2014, 10:34 a.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll try to \
reproduce it with a minimal test case, however I am away until Sunday, so it will be \
a while.</pre> </blockquote>
<p>On March 5th, 2014, 1:35 p.m. UTC, <b>Stephen Kelly</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've pushed a fix to \
the cmake next branch. Please test it instead of committing this patch.
Another point of note is that you shouldn't read the LOCATION property from the \
target. You get a policy warning about that. Use the target name directly \
instead.</pre> </blockquote>
<p>On March 10th, 2014, 1:50 p.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can confirm that using \
cmake next branch fixes the issue. How do I check that the currently used CMake \
version contains that fix?</pre> </blockquote>
<p>On March 12th, 2014, 3:36 p.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No idea, anyone?</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe you want 'NOT \
VERSION_LESS 3.0'. </pre>
<br />
<p>- Stephen</p>
<br />
<p>On March 4th, 2014, 8:45 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Stephen Kelly.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated March 4, 2014, 8:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix kservice_desktop_to_json for Visual Studio
The CMake generator for Visual Studio cannot handle the new build-time
kservice_desktop_to_json macro -> fall back to configure-time generation</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ktexteditor fails to build before this patch (because moc can't find \
the .json file), with the patch it compiles</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KF5ServiceMacros.cmake <span style="color: \
grey">(f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115918/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic