[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 116699: No longer use pid_t or Q_PID
From: "Oswald Buddenhagen" <ossi () kde ! org>
Date: 2014-03-12 10:09:20
Message-ID: 20140312100920.18225.2567 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116699/#review52731
-----------------------------------------------------------
there is QProcess::processId() since 5.3 (replacing KProcess::pid()). it simply \
returns a somewhat wasteful qint64. you may want to follow the same practice.
windows does of course not have a native getpid() function, but it is easy enough to \
replicate.
- Oswald Buddenhagen
On March 12, 2014, 7:36 a.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116699/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 7:36 a.m.)
>
>
> Review request for KDE Frameworks, David Faure and Oswald Buddenhagen.
>
>
> Repository: kio
>
>
> Description
> -------
>
> No longer use pid_t or Q_PID
>
> Instead use a new typedef KIO::ProcessId. This is needed for Windows where
> pid_t doesn't exist and Q_PID is actually a pointer to a structure
>
>
> Diffs
> -----
>
> src/core/global.h 7814a52c9656719d301ebd012434a53491ffe159
> src/core/idleslave.h d3e7add4460d38212858666afa22deb3e5ef8687
> src/core/idleslave.cpp 31d145e5d5e0c4205eb7deec6de7677061bb8a25
> src/core/scheduler.h 593174e770d24c6ef813d91dfb6d6ed716bba4f9
> src/core/scheduler.cpp 5a4ad310e34587249e0b50c67e011d516858e130
> src/core/slave.h e4a443d191faefa535072d3821bb84cb6ab55909
> src/core/slave.cpp 404a0c20f57e7c2badd7ac9c1294224d59960f7c
> src/core/slavebase.cpp a32c6b6ad2b803e24c1db75321aefb916678c03d
> src/core/slaveinterface.h 1ee7c1aebbf29271da605f33a5587974a4e71a5b
> src/core/slaveinterface.cpp f8d7d52864ab6dd11316a1252fbd1e372f7f9ee2
> src/widgets/krun.cpp 34708cc5a4b4cf3627deb750020104dd3593ef92
> src/widgets/krun_p.h cf44e327e6d5bac0fa69b989bd6036380fc5180c
>
> Diff: https://git.reviewboard.kde.org/r/116699/diff/
>
>
> Testing
> -------
>
> tests still pass
>
>
> Thanks,
>
> Alexander Richardson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116699/">https://git.reviewboard.kde.org/r/116699/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there is \
QProcess::processId() since 5.3 (replacing KProcess::pid()). it simply returns a \
somewhat wasteful qint64. you may want to follow the same practice.
windows does of course not have a native getpid() function, but it is easy enough to \
replicate.</pre> <br />
<p>- Oswald Buddenhagen</p>
<br />
<p>On March 12th, 2014, 7:36 a.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Oswald Buddenhagen.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated March 12, 2014, 7:36 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No longer use pid_t or Q_PID
Instead use a new typedef KIO::ProcessId. This is needed for Windows where
pid_t doesn't exist and Q_PID is actually a pointer to a structure</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tests still pass</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/global.h <span style="color: \
grey">(7814a52c9656719d301ebd012434a53491ffe159)</span></li>
<li>src/core/idleslave.h <span style="color: \
grey">(d3e7add4460d38212858666afa22deb3e5ef8687)</span></li>
<li>src/core/idleslave.cpp <span style="color: \
grey">(31d145e5d5e0c4205eb7deec6de7677061bb8a25)</span></li>
<li>src/core/scheduler.h <span style="color: \
grey">(593174e770d24c6ef813d91dfb6d6ed716bba4f9)</span></li>
<li>src/core/scheduler.cpp <span style="color: \
grey">(5a4ad310e34587249e0b50c67e011d516858e130)</span></li>
<li>src/core/slave.h <span style="color: \
grey">(e4a443d191faefa535072d3821bb84cb6ab55909)</span></li>
<li>src/core/slave.cpp <span style="color: \
grey">(404a0c20f57e7c2badd7ac9c1294224d59960f7c)</span></li>
<li>src/core/slavebase.cpp <span style="color: \
grey">(a32c6b6ad2b803e24c1db75321aefb916678c03d)</span></li>
<li>src/core/slaveinterface.h <span style="color: \
grey">(1ee7c1aebbf29271da605f33a5587974a4e71a5b)</span></li>
<li>src/core/slaveinterface.cpp <span style="color: \
grey">(f8d7d52864ab6dd11316a1252fbd1e372f7f9ee2)</span></li>
<li>src/widgets/krun.cpp <span style="color: \
grey">(34708cc5a4b4cf3627deb750020104dd3593ef92)</span></li>
<li>src/widgets/krun_p.h <span style="color: \
grey">(cf44e327e6d5bac0fa69b989bd6036380fc5180c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116699/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic