'Re: Review Request 115316: Add demo for KRecentFileList'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 115316: Add demo for KRecentFileList
From:       "Kevin Ottens" <ervin () kde ! org>
Date:       2014-03-04 20:29:55
Message-ID: 20140304202955.28067.27377 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115316/#review51937
-----------------------------------------------------------

Ship it!

Ship It!

- Kevin Ottens

On Feb. 24, 2014, 10:05 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115316/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 10:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> This is a demo test for KRecentFileList (in combination with KSharedConfig).
> 
> The patch also contains a documentation update for krecentfilesaction.h/loadEntries() saying \
> that "Local file entries that do not exist anymore are not restored.". 
> As a side note: Does it makes sense to optionally disable the automated removal of \
> non-existing recent files? Or have the possibility to return the files that were \
> automatically removed? 
> 
> Diffs
> -----
> 
> src/krecentfilesaction.h 38d1b5e3455d081304b064d13bccfc2164d12a14 
> tests/CMakeLists.txt 617a55944b2c91c9b09125ad92d070d3cd9a6551 
> tests/krecentfilesactiontest.h PRE-CREATION 
> tests/krecentfilesactiontest.cpp PRE-CREATION 
> tests/krecentfilesactiontest.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115316/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregor Mi
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115316/">https://git.reviewboard.kde.org/r/115316/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Kevin Ottens</p>

<br />
<p>On February 24th, 2014, 10:05 p.m. UTC, Gregor Mi wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Gregor Mi.</div>

<p style="color: grey;"><i>Updated Feb. 24, 2014, 10:05 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfigwidgets
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a demo test \
for KRecentFileList (in combination with KSharedConfig).

The patch also contains a documentation update for krecentfilesaction.h/loadEntries() saying \
that &quot;Local file entries that do not exist anymore are not restored.&quot;.

As a side note: Does it makes sense to optionally disable the automated removal of non-existing \
recent files? Or have the possibility to return the files that were automatically removed? \
</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/krecentfilesaction.h <span style="color: \
grey">(38d1b5e3455d081304b064d13bccfc2164d12a14)</span></li>

 <li>tests/CMakeLists.txt <span style="color: \
grey">(617a55944b2c91c9b09125ad92d070d3cd9a6551)</span></li>

 <li>tests/krecentfilesactiontest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/krecentfilesactiontest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/krecentfilesactiontest.ui <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115316/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 