[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 116026: Remove the WebP format
From: "Alex Merry" <kde () randomguy3 ! me ! uk>
Date: 2014-02-25 12:17:06
Message-ID: 20140225121706.11047.43768 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116026/
-----------------------------------------------------------
(Updated Feb. 25, 2014, 12:17 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: kimageformats
Description
-------
Remove the WebP format
This will be in Qt 5.3.
The desktop file should go into kde4support. What about the XML file? I've got rid of it \
here, but we could keep it. Bear in mind that it will be in the next release of \
shared-mime-info.
Diffs
-----
autotests/CMakeLists.txt 3e30e600216fabf233f5f93b0b64cc368c47b6d5
autotests/read/webp/bw-cwebp-lossless.png e2d506bb3da276c09b8f9388dc8ad6b96f987f5e
autotests/read/webp/bw-cwebp-lossless.webp 3567af16a140d9af685229cb754014476d4bbc35
autotests/read/webp/bw-cwebp.png ea9dcea82f70750467390f6b26624bd4746013f9
autotests/read/webp/bw-cwebp.webp 9c2e0c0a96eb64c035a8689a93c8a651075152a6
autotests/read/webp/rgb-cwebp-lossless.png 267d67841ad5f80e0f36cbf514c33d6e9cac146b
autotests/read/webp/rgb-cwebp-lossless.webp 0151334e7db32d96aae733095aea3aeefa262629
autotests/read/webp/rgb-cwebp.png 528df3fd8e1271cbbcc58618820ad58903a17681
autotests/read/webp/rgb-cwebp.webp d889a9b5e874e319449e7bc2fb4367fbdcdd830e
src/imageformats/CMakeLists.txt 07ce79e82440fef120dad835ba45386481a73594
src/imageformats/webp.cpp c92b7bbd093bccb7e6eb6c34dc23dae4c1cd0436
src/imageformats/webp.desktop 3526be5f1f01907b18c3bd80cf5fb3f0b29a24c4
src/imageformats/webp.h 91e724e3877e9f7ec6acb8c36f0f06f86cc3bac1
src/imageformats/webp.json 9e81ff966ded7b3c415217aef998bf25d9becc55
src/imageformats/webp.xml 68ddbbf334031ea8d023b16a4904f07b8cc8d0ba
Diff: https://git.reviewboard.kde.org/r/116026/diff/
Testing
-------
Compiles, installs, tests pass.
Thanks,
Alex Merry
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116026/">https://git.reviewboard.kde.org/r/116026/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2014, 12:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove the WebP \
format
This will be in Qt 5.3.
The desktop file should go into kde4support. What about the XML file? I've got rid of it \
here, but we could keep it. Bear in mind that it will be in the next release of \
shared-mime-info.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, installs, \
tests pass.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: \
grey">(3e30e600216fabf233f5f93b0b64cc368c47b6d5)</span></li>
<li>autotests/read/webp/bw-cwebp-lossless.png <span style="color: \
grey">(e2d506bb3da276c09b8f9388dc8ad6b96f987f5e)</span></li>
<li>autotests/read/webp/bw-cwebp-lossless.webp <span style="color: \
grey">(3567af16a140d9af685229cb754014476d4bbc35)</span></li>
<li>autotests/read/webp/bw-cwebp.png <span style="color: \
grey">(ea9dcea82f70750467390f6b26624bd4746013f9)</span></li>
<li>autotests/read/webp/bw-cwebp.webp <span style="color: \
grey">(9c2e0c0a96eb64c035a8689a93c8a651075152a6)</span></li>
<li>autotests/read/webp/rgb-cwebp-lossless.png <span style="color: \
grey">(267d67841ad5f80e0f36cbf514c33d6e9cac146b)</span></li>
<li>autotests/read/webp/rgb-cwebp-lossless.webp <span style="color: \
grey">(0151334e7db32d96aae733095aea3aeefa262629)</span></li>
<li>autotests/read/webp/rgb-cwebp.png <span style="color: \
grey">(528df3fd8e1271cbbcc58618820ad58903a17681)</span></li>
<li>autotests/read/webp/rgb-cwebp.webp <span style="color: \
grey">(d889a9b5e874e319449e7bc2fb4367fbdcdd830e)</span></li>
<li>src/imageformats/CMakeLists.txt <span style="color: \
grey">(07ce79e82440fef120dad835ba45386481a73594)</span></li>
<li>src/imageformats/webp.cpp <span style="color: \
grey">(c92b7bbd093bccb7e6eb6c34dc23dae4c1cd0436)</span></li>
<li>src/imageformats/webp.desktop <span style="color: \
grey">(3526be5f1f01907b18c3bd80cf5fb3f0b29a24c4)</span></li>
<li>src/imageformats/webp.h <span style="color: \
grey">(91e724e3877e9f7ec6acb8c36f0f06f86cc3bac1)</span></li>
<li>src/imageformats/webp.json <span style="color: \
grey">(9e81ff966ded7b3c415217aef998bf25d9becc55)</span></li>
<li>src/imageformats/webp.xml <span style="color: \
grey">(68ddbbf334031ea8d023b16a4904f07b8cc8d0ba)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116026/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic