[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 116014: Add a FindEgl module
From: "Alex Merry" <kde () randomguy3 ! me ! uk>
Date: 2014-02-25 11:46:47
Message-ID: 20140225114647.20335.44753 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116014/#review50800
-----------------------------------------------------------
Generally looks good, but I'm wondering about the WIN32 clause. EGL is really just an API, \
right? What we're really searching for is the Mesa implementation. I guess that other \
platforms may well have their own implementations that, long term, it would be nice for this \
file to look for. In the meantime, it probably makes sense to print a message on WIN32 about \
how we're not looking for anything. Some of the stuff should then go outside the WIN32 clause, \
like find_package_handle_standard_args and set_package_properties.
Also: what about APPLE? Does that use Mesa?
Also: capitalisation. Shouldn't it be EGL, rather than Egl?
- Alex Merry
On Feb. 25, 2014, 10:21 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116014/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2014, 10:21 a.m.)
>
>
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Alex Merry.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Add a FindEgl module
>
> This module finds the egl library through pkg-config.
>
>
> Diffs
> -----
>
> find-modules/FindEgl.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/116014/diff/
>
>
> Testing
> -------
>
> Adjusted KWin to find egl through this cmake module. Picks up egl, compiles and links.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116014/">https://git.reviewboard.kde.org/r/116014/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Generally looks good, but I'm wondering \
about the WIN32 clause. EGL is really just an API, right? What we're really searching for \
is the Mesa implementation. I guess that other platforms may well have their own \
implementations that, long term, it would be nice for this file to look for. In the meantime, \
it probably makes sense to print a message on WIN32 about how we're not looking for \
anything. Some of the stuff should then go outside the WIN32 clause, like \
find_package_handle_standard_args and set_package_properties.
Also: what about APPLE? Does that use Mesa?
Also: capitalisation. Shouldn't it be EGL, rather than Egl?</pre>
<br />
<p>- Alex Merry</p>
<br />
<p>On February 25th, 2014, 10:21 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Alex \
Merry.</div> <div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2014, 10:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a FindEgl module
This module finds the egl library through pkg-config.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adjusted KWin to find \
egl through this cmake module. Picks up egl, compiles and links.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/FindEgl.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116014/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic