--===============6846802303258265111== Content-Type: multipart/alternative; boundary="===============0896756252521887790==" --===============0896756252521887790== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115316/ ----------------------------------------------------------- (Updated Feb. 24, 2014, 10:05 p.m.) Review request for KDE Frameworks. Changes ------- Rename KRecentFilesActionDemo to KRecentFilesActionTest Repository: kconfigwidgets Description ------- This is a demo test for KRecentFileList (in combination with KSharedConfig). The patch also contains a documentation update for krecentfilesaction.h/loadEntries() saying that "Local file entries that do not exist anymore are not restored.". As a side note: Does it makes sense to optionally disable the automated removal of non-existing recent files? Or have the possibility to return the files that were automatically removed? Diffs (updated) ----- src/krecentfilesaction.h 38d1b5e3455d081304b064d13bccfc2164d12a14 tests/CMakeLists.txt 617a55944b2c91c9b09125ad92d070d3cd9a6551 tests/krecentfilesactiontest.h PRE-CREATION tests/krecentfilesactiontest.cpp PRE-CREATION tests/krecentfilesactiontest.ui PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115316/diff/ Testing ------- Thanks, Gregor Mi --===============0896756252521887790== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115316/

Review request for KDE Frameworks.
By Gregor Mi.

Updated Feb. 24, 2014, 10:05 p.m.

Changes

Rename KRecentFilesActionDemo to KRecentFilesActionTest
Repository: kconfigwidgets

Description 

This is a demo test for KRecentFileList (in combination with KSharedConfig).

The patch also contains a documentation update for krecentfilesaction.h/loadEntries() saying that "Local file entries that do not exist anymore are not restored.".

As a side note: Does it makes sense to optionally disable the automated removal of non-existing recent files? Or have the possibility to return the files that were automatically removed?

Diffs (updated)

  • src/krecentfilesaction.h (38d1b5e3455d081304b064d13bccfc2164d12a14)
  • tests/CMakeLists.txt (617a55944b2c91c9b09125ad92d070d3cd9a6551)
  • tests/krecentfilesactiontest.h (PRE-CREATION)
  • tests/krecentfilesactiontest.cpp (PRE-CREATION)
  • tests/krecentfilesactiontest.ui (PRE-CREATION)

View Diff
--===============0896756252521887790==-- --===============6846802303258265111== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============6846802303258265111==--