This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/

On February 24th, 2014, 3:55 p.m. CET, Alex Merry wrote:

Same comments as for FindEGL.cmake:
- what projects are using it?  I guess KWin is one; any others?
- it needs to set the DESCRIPTION and URL package properties (from FeatureSummary)
- I've been aiming to create imported targets in new find modules, because they're easier to use (see FindSharedMimeInfo.cmake for an example, or the modules in kimageformats for better examples).
and I can kind of give the same answer. Currently KWin is using it (we have a bad find module in kde-workspace) and for KInfoCenter I created a review request today which adds a dependency. I expect that in future almost every framework which has a FindXCB or FindX11 will also get a FindWayland.

- Martin


On February 24th, 2014, 2:52 p.m. CET, Martin Gräßlin wrote:

Review request for KDE Frameworks and Alex Merry.
By Martin Gräßlin.

Updated Feb. 24, 2014, 2:52 p.m.

Repository: extra-cmake-modules

Description

Add a FindWayland module

Inspired by the FindXCB module it's using components to simplify
finding just the parts which are really required.

Testing

Changed kde-workspace to use this component based variant.

Diffs

  • find-modules/FindWayland.cmake (PRE-CREATION)

View Diff