This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/ |
Same comments as for FindEGL.cmake: - what projects are using it? I guess KWin is one; any others? - it needs to set the DESCRIPTION and URL package properties (from FeatureSummary) - I've been aiming to create imported targets in new find modules, because they're easier to use (see FindSharedMimeInfo.cmake for an example, or the modules in kimageformats for better examples).
- Alex Merry
On February 24th, 2014, 1:52 p.m. UTC, Martin Gräßlin wrote:
Review request for KDE Frameworks and Alex Merry.
By Martin Gräßlin.
Updated Feb. 24, 2014, 1:52 p.m.
Repository:
extra-cmake-modules
Description
Testing
Diffs
|