From kde-frameworks-devel Mon Feb 24 14:55:28 2014 From: "Alex Merry" Date: Mon, 24 Feb 2014 14:55:28 +0000 To: kde-frameworks-devel Subject: Re: Review Request 116018: Add a FindWayland module Message-Id: <20140224145528.14197.40133 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=139325374224117 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6086364487028554036==" --===============6086364487028554036== Content-Type: multipart/alternative; boundary="===============3679250449389333644==" --===============3679250449389333644== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/#review50706 ----------------------------------------------------------- Same comments as for FindEGL.cmake: - what projects are using it? I guess KWin is one; any others? - it needs to set the DESCRIPTION and URL package properties (from FeatureSummary) - I've been aiming to create imported targets in new find modules, because they're easier to use (see FindSharedMimeInfo.cmake for an example, or the modules in kimageformats for better examples). - Alex Merry On Feb. 24, 2014, 1:52 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116018/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 1:52 p.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: extra-cmake-modules > > > Description > ------- > > Add a FindWayland module > > Inspired by the FindXCB module it's using components to simplify > finding just the parts which are really required. > > > Diffs > ----- > > find-modules/FindWayland.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/116018/diff/ > > > Testing > ------- > > Changed kde-workspace to use this component based variant. > > > Thanks, > > Martin Gräßlin > > --===============3679250449389333644== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/

Same comments as for FindEGL.cmake:
- what projects are using it?  I guess KWin is one; any others?
- it needs to set the DESCRIPTION and URL package properties (from FeatureSummary)
- I've been aiming to create imported targets in new find modules, because they're easier to use (see FindSharedMimeInfo.cmake for an example, or the modules in kimageformats for better examples).

- Alex Merry

On February 24th, 2014, 1:52 p.m. UTC, Martin Gräßlin wrote:

Review request for KDE Frameworks and Alex Merry.

By Martin Gräßlin.

Updated Feb. 24, 2014, 1:52 p.m.

Repository: extra-cmake-modules

Description

Add a FindWayland module

Inspired by the FindXCB module it's using components to simplify
finding just the parts which are really required.

Testing

Changed kde-workspace to use this component based variant.

Diffs

find-modules/FindWayland.cmake (PRE-CREATION)

View Diff

--===============3679250449389333644==-- --===============6086364487028554036== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============6086364487028554036==--