'Review Request 116012: Inline deprecated methods, and silence false positives in tests'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 116012: Inline deprecated methods, and silence false positives in tests
From:       "Alex Merry" <kde () randomguy3 ! me ! uk>
Date:       2014-02-24 12:12:05
Message-ID: 20140224121205.14197.54604 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116012/
-----------------------------------------------------------

Review request for KDE Frameworks.

Repository: karchive

Description
-------

Four commits (in git log order):

Simplify autotests CMakeLists.txt

Separate out tests of deprecated functions to their own file

This allows us to disable deprecation warnings just for that file.

Inline deprecated methods

This both documents how to replace them in the headers and ensures that
enabling or disabling deprecated functions does not affect the ABI.

Use KARCHIVE_NO_DEPRECATED instead of KDE_NO_DEPRECATED

Diffs
-----

  autotests/CMakeLists.txt 1da853fe49ec6fca40ccf417db788340124b41e5 
  autotests/deprecatedtest.cpp PRE-CREATION 
  autotests/karchivetest.cpp 6d6b5848ce9add84736968dd13f529711f895493 
  src/karchive.h d4209cf334190dda735fcb4687fa102a4e7a73cd 
  src/karchive.cpp a25b85e41618d1f7ae62e7e41966afe1a8aaef8e 
  src/kfilterdev.h 4a35879a15992d19378c7e9baa9b206e187713fd 
  src/kfilterdev.cpp 60660a0c08922ee0f4ddaf4ad4d1adf0e7f1c5a3 

Diff: https://git.reviewboard.kde.org/r/116012/diff/

Testing
-------

Builds, tests pass.  No deprecation warnings (before there were two in the tests).

Thanks,

Alex Merry

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116012/">https://git.reviewboard.kde.org/r/116012/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
karchive
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Four commits (in git \
log order):

Simplify autotests CMakeLists.txt

Separate out tests of deprecated functions to their own file

This allows us to disable deprecation warnings just for that file.

Inline deprecated methods

This both documents how to replace them in the headers and ensures that
enabling or disabling deprecated functions does not affect the ABI.

Use KARCHIVE_NO_DEPRECATED instead of KDE_NO_DEPRECATED</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, tests pass.  \
No deprecation warnings (before there were two in the tests).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/CMakeLists.txt <span style="color: \
grey">(1da853fe49ec6fca40ccf417db788340124b41e5)</span></li>

 <li>autotests/deprecatedtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/karchivetest.cpp <span style="color: \
grey">(6d6b5848ce9add84736968dd13f529711f895493)</span></li>

 <li>src/karchive.h <span style="color: \
grey">(d4209cf334190dda735fcb4687fa102a4e7a73cd)</span></li>

 <li>src/karchive.cpp <span style="color: \
grey">(a25b85e41618d1f7ae62e7e41966afe1a8aaef8e)</span></li>

 <li>src/kfilterdev.h <span style="color: \
grey">(4a35879a15992d19378c7e9baa9b206e187713fd)</span></li>

 <li>src/kfilterdev.cpp <span style="color: \
grey">(60660a0c08922ee0f4ddaf4ad4d1adf0e7f1c5a3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116012/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 