'Review Request 115953: Clean up kdesu CMake files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 115953: Clean up kdesu CMake files
From:       "Alex Merry" <kde () randomguy3 ! me ! uk>
Date:       2014-02-22 17:43:34
Message-ID: 20140222174334.24989.97648 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115953/
-----------------------------------------------------------

Review request for KDE Frameworks.

Repository: kdesu

Description
-------

Remove KF5Service dependency from config file

KF5Service is a PRIVATE link, and so should not be a dependency in the
config file.

Remove leftover code from kdelibs from CMakeLists.txt

Diffs
-----

  CMakeLists.txt 15b01a0745206cbc761fd3572393ec56753ff2b6 
  KF5SuConfig.cmake.in 9c2f96e3712490c56fd697b862c5d6a39755402d 

Diff: https://git.reviewboard.kde.org/r/115953/diff/

Testing
-------

Configures, compiles, installs.

Thanks,

Alex Merry

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115953/">https://git.reviewboard.kde.org/r/115953/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdesu
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove KF5Service \
dependency from config file

KF5Service is a PRIVATE link, and so should not be a dependency in the
config file.

Remove leftover code from kdelibs from CMakeLists.txt</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Configures, compiles, \
installs.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(15b01a0745206cbc761fd3572393ec56753ff2b6)</span></li>

 <li>KF5SuConfig.cmake.in <span style="color: \
grey">(9c2f96e3712490c56fd697b862c5d6a39755402d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115953/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 