--===============2774808921599429284== Content-Type: multipart/alternative; boundary="===============7506041063469188062==" --===============7506041063469188062== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115028/ ----------------------------------------------------------- (Updated Feb. 22, 2014, 5:28 p.m.) Review request for KDE Frameworks. Changes ------- Do not disable internal deprecated warnings. Repository: kcoreaddons Description (updated) ------- Inline deprecated KUser::fullName() method Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED KCOREADDONS_NO_DEPRECATED is the macro controlled by generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs. Diffs (updated) ----- src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0 src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d Diff: https://git.reviewboard.kde.org/r/115028/diff/ Testing ------- configures, compiles, tests pass (well, except KDirWatch-FAM, which has never passed for me). Thanks, Alex Merry --===============7506041063469188062== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115028/

Review request for KDE Frameworks.
By Alex Merry.

Updated Feb. 22, 2014, 5:28 p.m.

Changes

Do not disable internal deprecated warnings.
Repository: kcoreaddons

Description (updated)

Inline deprecated KUser::fullName() method


Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED

KCOREADDONS_NO_DEPRECATED is the macro controlled by
generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs.

Testing 

configures, compiles, tests pass (well, except KDirWatch-FAM, which has never passed for me).

Diffs (updated)

  • src/lib/util/kuser.h (2b6e6ed92bc1465945f36f2fde821f36fa51585f)
  • src/lib/util/kuser_unix.cpp (8a3a39d379ca863b4906bb01228c5e01a5b955b0)
  • src/lib/util/kuser_win.cpp (6a6cbb1751bd569d8684f8e11add1ef304c0a94d)

View Diff
--===============7506041063469188062==-- --===============2774808921599429284== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============2774808921599429284==--