--===============8003597014914780929== Content-Type: multipart/alternative; boundary="===============4251318448439400435==" --===============4251318448439400435== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115909/#review50537 ----------------------------------------------------------- This review has been submitted with commit b2507733f491e9ad291214ca11fd97631df2bb66 by Michael Palimaka to branch master. - Commit Hook On Feb. 20, 2014, 12:22 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115909/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 12:22 p.m.) > > > Review request for KDE Frameworks. > > > Repository: krunner > > > Description > ------- > > There does not appear to be any actual KCompletion usage, so remove it. > > > Diffs > ----- > > src/runnercontext.cpp 8b7461459ead6ff8c18549531f1b5c9baf1df3fa > CMakeLists.txt ebae16d0610c5c53aac34e9134db5d4b0e47903b > src/CMakeLists.txt 0f8221fc175f51da32a5abcc96bdeca2c9b0e17b > src/abstractrunner.h cee292812075db59c13703de37dc1e983c3d8968 > src/runnercontext.h c6441b7a1bb92df5549d26f45183c1ff7ce157e6 > > Diff: https://git.reviewboard.kde.org/r/115909/diff/ > > > Testing > ------- > > Builds. Tests pass. > > > Thanks, > > Michael Palimaka > > --===============4251318448439400435== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115909/ 

This review has been submitted with commit b2507733f491e9ad291214ca11fd97631df2bb66 by Michael Palimaka to branch master.

- Commit Hook


On February 20th, 2014, 12:22 p.m. UTC, Michael Palimaka wrote:

Review request for KDE Frameworks.
By Michael Palimaka.

Updated Feb. 20, 2014, 12:22 p.m.

Repository: krunner

Description 

There does not appear to be any actual KCompletion usage, so remove it.

Testing 

Builds. Tests pass.

Diffs

  • src/runnercontext.cpp (8b7461459ead6ff8c18549531f1b5c9baf1df3fa)
  • CMakeLists.txt (ebae16d0610c5c53aac34e9134db5d4b0e47903b)
  • src/CMakeLists.txt (0f8221fc175f51da32a5abcc96bdeca2c9b0e17b)
  • src/abstractrunner.h (cee292812075db59c13703de37dc1e983c3d8968)
  • src/runnercontext.h (c6441b7a1bb92df5549d26f45183c1ff7ce157e6)

View Diff
--===============4251318448439400435==-- --===============8003597014914780929== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============8003597014914780929==--