'Re: Review Request 115485: Porting KTranscript from KJS to QtScript'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 115485: Porting KTranscript from KJS to QtScript
From:       "Michael Palimaka" <kensington () gentoo ! org>
Date:       2014-02-22 15:24:35
Message-ID: 20140222152435.7230.35006 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115485/#review50535
-----------------------------------------------------------

If this is tier 1 now, please don't forget to update the wiki and the yaml file.

- Michael Palimaka

On Feb. 22, 2014, 2:15 p.m., Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115485/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2014, 2:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Attempt at replacing the KJS dependency with a QtScript, i.e. making ki18n a tier1 framework.
> Needs more testing and likely fixing
> 
> 
> Diffs
> -----
> 
> autotests/CMakeLists.txt c4d6b9b 
> src/CMakeLists.txt 9e3ce9f 
> src/ktranscript.cpp b9e0551 
> CMakeLists.txt 06fb696 
> 
> Diff: https://git.reviewboard.kde.org/r/115485/diff/
> 
> 
> Testing
> -------
> 
> Unittest runs, but the test script is very minimal and would need to be extendedb by someone \
> who understands the scripting requirements. There is also a weird crash at test shutdown, in \
> QThreadStorage. As far as I can tell I did not change anything related to threads though. 
> 
> Thanks,
> 
> Kevin Krammer
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115485/">https://git.reviewboard.kde.org/r/115485/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">If this is tier 1 now, please don&#39;t \
forget to update the wiki and the yaml file.</pre>  <br />

<p>- Michael Palimaka</p>

<br />
<p>On February 22nd, 2014, 2:15 p.m. UTC, Kevin Krammer wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Chusslove Illich.</div>
<div>By Kevin Krammer.</div>

<p style="color: grey;"><i>Updated Feb. 22, 2014, 2:15 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Attempt at replacing \
the KJS dependency with a QtScript, i.e. making ki18n a tier1 framework. Needs more testing and \
likely fixing</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unittest runs, but \
the test script is very minimal and would need to be extendedb by someone who understands the \
scripting requirements. There is also a weird crash at test shutdown, in QThreadStorage. As far \
as I can tell I did not change anything related to threads though.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/CMakeLists.txt <span style="color: grey">(c4d6b9b)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(9e3ce9f)</span></li>

 <li>src/ktranscript.cpp <span style="color: grey">(b9e0551)</span></li>

 <li>CMakeLists.txt <span style="color: grey">(06fb696)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115485/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 