[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 115316: Add demo for KRecentFileList
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2014-02-21 6:47:52
Message-ID: 20140221064752.27042.29242 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 27, 2014, 2:23 a.m., Aleix Pol Gonzalez wrote:
> > It's a test, not a demo. If you want, it's for demonstrating the developer that he did it \
> > right, but I wouldn't see it as documentation.
> > I would rename it to KRecentFilesActionTest
>
> Kevin Ottens wrote:
> Yes, definitely a manual test (otherwise wouldn't be allowed in tests/ but in examples/ \
> instead).
> Gregor Mi wrote:
> Ok, I will rename it. In the test/ folder there is also kcolorutilsdemo.cpp and \
> kcolorschemedemo.cpp, so I was not sure which is correct.
> Alex Merry wrote:
> Any progress on this?
Please update this review ASAP.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115316/#review48327
-----------------------------------------------------------
On Jan. 25, 2014, 10:56 p.m., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115316/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2014, 10:56 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kconfigwidgets
>
>
> Description
> -------
>
> This is a demo test for KRecentFileList (in combination with KSharedConfig).
>
> The patch also contains a documentation update for krecentfilesaction.h/loadEntries() saying \
> that "Local file entries that do not exist anymore are not restored.".
> As a side note: Does it makes sense to optionally disable the automated removal of \
> non-existing recent files? Or have the possibility to return the files that were \
> automatically removed?
>
> Diffs
> -----
>
> src/krecentfilesaction.h 38d1b5e3455d081304b064d13bccfc2164d12a14
> tests/CMakeLists.txt 617a55944b2c91c9b09125ad92d070d3cd9a6551
> tests/krecentfilesactiondemo.h PRE-CREATION
> tests/krecentfilesactiondemo.cpp PRE-CREATION
> tests/krecentfilesactiondemo.ui PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/115316/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gregor Mi
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115316/">https://git.reviewboard.kde.org/r/115316/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2014, 2:23 a.m. UTC, <b>Aleix Pol Gonzalez</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">It's a test, not a demo. If you want, \
it's for demonstrating the developer that he did it right, but I wouldn't see it as \
documentation.
I would rename it to KRecentFilesActionTest</pre>
</blockquote>
<p>On January 27th, 2014, 8:02 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Yes, definitely a manual test (otherwise \
wouldn't be allowed in tests/ but in examples/ instead).</pre> </blockquote>
<p>On January 27th, 2014, 6:57 p.m. UTC, <b>Gregor Mi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I will rename it. In the test/ folder \
there is also kcolorutilsdemo.cpp and kcolorschemedemo.cpp, so I was not sure which is \
correct.</pre> </blockquote>
<p>On February 19th, 2014, 1:28 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Any progress on this?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Please update this review ASAP.</pre> <br />
<p>- Kevin</p>
<br />
<p>On January 25th, 2014, 10:56 p.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2014, 10:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfigwidgets
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a demo test \
for KRecentFileList (in combination with KSharedConfig).
The patch also contains a documentation update for krecentfilesaction.h/loadEntries() saying \
that "Local file entries that do not exist anymore are not restored.".
As a side note: Does it makes sense to optionally disable the automated removal of non-existing \
recent files? Or have the possibility to return the files that were automatically removed? \
</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/krecentfilesaction.h <span style="color: \
grey">(38d1b5e3455d081304b064d13bccfc2164d12a14)</span></li>
<li>tests/CMakeLists.txt <span style="color: \
grey">(617a55944b2c91c9b09125ad92d070d3cd9a6551)</span></li>
<li>tests/krecentfilesactiondemo.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/krecentfilesactiondemo.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/krecentfilesactiondemo.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115316/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic