[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 115355: Import the WebP image I/O code from kde-runtime
From: "Alex Merry" <kde () randomguy3 ! me ! uk>
Date: 2014-02-20 12:56:33
Message-ID: 20140220125633.1865.35828 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115355/
-----------------------------------------------------------
(Updated Feb. 20, 2014, 12:56 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: kimageformats
Description
-------
WebP: use Q_DECL_OVERRIDE
In doing so, found a method that should not have been overridden, and so
removed it.
WebP: remove unused include
Make WebP mimetype xml match the one in shared-mime-info-git
This includes the detection magic and an alias for image/webp. It
should be in shared-mime-info 1.3.
Proposed by Jerome Leclanche <adys.wh@gmail.com>.
Import the WebP image I/O code from kde-runtime
The plugin export mechanism has been patched up (including the addition
of the JSON file), and the FindWebP.cmake file is new.
Writing is currently disabled, as it produces broken images.
Autotests are generated using the cwebp and dwebp utilities distributed
with the libwebp reference library.
Diffs
-----
src/imageformats/webp.json PRE-CREATION
src/imageformats/webp.xml PRE-CREATION
cmake/FindWebP.cmake PRE-CREATION
autotests/read/webp/rgb-cwebp.webp PRE-CREATION
autotests/read/webp/rgb-cwebp.png PRE-CREATION
autotests/read/webp/rgb-cwebp-lossless.webp PRE-CREATION
autotests/read/webp/rgb-cwebp-lossless.png PRE-CREATION
autotests/read/webp/bw-cwebp.webp PRE-CREATION
autotests/read/webp/bw-cwebp.png PRE-CREATION
autotests/read/webp/bw-cwebp-lossless.webp PRE-CREATION
autotests/read/webp/bw-cwebp-lossless.png PRE-CREATION
autotests/CMakeLists.txt bedc3ad451128365699ec8f1392c68993934453b
src/imageformats/webp.h PRE-CREATION
src/imageformats/webp.desktop PRE-CREATION
src/imageformats/webp.cpp PRE-CREATION
src/imageformats/CMakeLists.txt 7cafd18105a7219a9c761193012f87625f74d995
Diff: https://git.reviewboard.kde.org/r/115355/diff/
Testing
-------
Compiles; installs; autotests run
Thanks,
Alex Merry
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115355/">https://git.reviewboard.kde.org/r/115355/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2014, 12:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">WebP: use \
Q_DECL_OVERRIDE
In doing so, found a method that should not have been overridden, and so
removed it.
WebP: remove unused include
Make WebP mimetype xml match the one in shared-mime-info-git
This includes the detection magic and an alias for image/webp. It
should be in shared-mime-info 1.3.
Proposed by Jerome Leclanche <adys.wh@gmail.com>.
Import the WebP image I/O code from kde-runtime
The plugin export mechanism has been patched up (including the addition
of the JSON file), and the FindWebP.cmake file is new.
Writing is currently disabled, as it produces broken images.
Autotests are generated using the cwebp and dwebp utilities distributed
with the libwebp reference library.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles; installs; \
autotests run</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/imageformats/webp.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/webp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/FindWebP.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/rgb-cwebp.webp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/rgb-cwebp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/rgb-cwebp-lossless.webp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/rgb-cwebp-lossless.png <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/bw-cwebp.webp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/bw-cwebp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/bw-cwebp-lossless.webp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/bw-cwebp-lossless.png <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/CMakeLists.txt <span style="color: \
grey">(bedc3ad451128365699ec8f1392c68993934453b)</span></li>
<li>src/imageformats/webp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/webp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/webp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/CMakeLists.txt <span style="color: \
grey">(7cafd18105a7219a9c761193012f87625f74d995)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115355/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic