[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 115586: Improve attica tests
From: "Alex Merry" <kde () randomguy3 ! me ! uk>
Date: 2014-02-20 10:39:42
Message-ID: 20140220103942.1865.93642 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115586/#review50326
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Merry
On Feb. 20, 2014, 10:16 a.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115586/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 10:16 a.m.)
>
>
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
>
>
> Repository: attica
>
>
> Description
> -------
>
> - Use BUILD_TESTING from ECM instead of custom ATTICA_ENABLE_TESTS
> - Remove enable_testing since this is done automatically by KDECMakeSettings
> - Mark tests
>
>
> Diffs
> -----
>
> CMakeLists.txt b7bfebdb334bfa6a2f352414e898175ef36707f1
> autotests/CMakeLists.txt e4a455730fd1faddf547b6c91d4477d707f41551
> tests/projecttest/CMakeLists.txt 0fce1bf8b2f9f93b9ee5b7961a12aeecdc8828a8
>
> Diff: https://git.reviewboard.kde.org/r/115586/diff/
>
>
> Testing
> -------
>
> Builds. Tests pass when enabled, and do not run when not.
>
>
> Thanks,
>
> Michael Palimaka
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115586/">https://git.reviewboard.kde.org/r/115586/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Alex Merry</p>
<br />
<p>On February 20th, 2014, 10:16 a.m. UTC, Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2014, 10:16 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
attica
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Use BUILD_TESTING \
from ECM instead of custom ATTICA_ENABLE_TESTS
- Remove enable_testing since this is done automatically by KDECMakeSettings
- Mark tests</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds. Tests pass \
when enabled, and do not run when not.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(b7bfebdb334bfa6a2f352414e898175ef36707f1)</span></li>
<li>autotests/CMakeLists.txt <span style="color: \
grey">(e4a455730fd1faddf547b6c91d4477d707f41551)</span></li>
<li>tests/projecttest/CMakeLists.txt <span style="color: \
grey">(0fce1bf8b2f9f93b9ee5b7961a12aeecdc8828a8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115586/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic