[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 115829: Add clickMessage property to classes formerly inheriting from KLineEdit
From: "Alex Merry" <kde () randomguy3 ! me ! uk>
Date: 2014-02-20 10:37:40
Message-ID: 20140220103740.1865.88534 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115829/#review50324
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Merry
On Feb. 20, 2014, 7:07 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115829/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 7:07 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kitemviews
>
>
> Description
> -------
>
> Add clickMessage property to classes formerly inheriting from KLineEdit
>
> ClickMessage is a deprecated property in KLineEdit. To increase SC its
> added back as a deprecated property to KListWidgetSearchLine and
> KTreeWidgetSearchLine which used to inherit from KLineEdit.
>
>
> Diffs
> -----
>
> src/klistwidgetsearchline.h 984a6ce2523f1e130b1bd5e945f018c05cd1b7c8
> src/ktreewidgetsearchline.h f597ed686ed81615e7558d9903a5f384b94ef79c
>
> Diff: https://git.reviewboard.kde.org/r/115829/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115829/">https://git.reviewboard.kde.org/r/115829/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Alex Merry</p>
<br />
<p>On February 20th, 2014, 7:07 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2014, 7:07 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kitemviews
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add clickMessage \
property to classes formerly inheriting from KLineEdit
ClickMessage is a deprecated property in KLineEdit. To increase SC its
added back as a deprecated property to KListWidgetSearchLine and
KTreeWidgetSearchLine which used to inherit from KLineEdit.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/klistwidgetsearchline.h <span style="color: \
grey">(984a6ce2523f1e130b1bd5e945f018c05cd1b7c8)</span></li>
<li>src/ktreewidgetsearchline.h <span style="color: \
grey">(f597ed686ed81615e7558d9903a5f384b94ef79c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115829/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic