'Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2014-02-13 13:41:19
Message-ID: 20140213134119.13918.67039 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115723/#review49709
-----------------------------------------------------------

Ship it!

That seems like a reasonable compromise to me. I wonder what Mozilla/Chromium send \
when the windowing system is something other than X11. Probably the same thing.

- Dawit Alemayehu

On Feb. 13, 2014, 1:03 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115723/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 1:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on
> 
> We cannot properly determine the windowing system platform on unix
> like systems in kprotocolmanager as it's not linking gui. Thus we
> don't know whether we are on X11 or Wayland and there is no proper
> way to figure it out, because both DISPLAY and WAYLAND_DISPLAY could
> be defined.
> 
> As a solution we just force the platform to be always X11 when we
> are on unix like systems (modulo mac).
> 
> 
> Diffs
> -----
> 
> src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 
> 
> Diff: https://git.reviewboard.kde.org/r/115723/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115723/">https://git.reviewboard.kde.org/r/115723/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That seems like a \
reasonable compromise to me. I wonder what Mozilla/Chromium send when the windowing \
system is something other than X11. Probably the same thing.</pre>  <br />

<p>- Dawit Alemayehu</p>

<br />
<p>On February 13th, 2014, 1:03 p.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Feb. 13, 2014, 1:03 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

We cannot properly determine the windowing system platform on unix
like systems in kprotocolmanager as it&#39;s not linking gui. Thus we
don&#39;t know whether we are on X11 or Wayland and there is no proper
way to figure it out, because both DISPLAY and WAYLAND_DISPLAY could
be defined.

As a solution we just force the platform to be always X11 when we
are on unix like systems (modulo mac).</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/kprotocolmanager.cpp <span style="color: \
grey">(f81b6797887eebd868c36b98e867eb055b05a1e2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115723/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 