'Re: Review Request 115353: Rename dbus interface files for solid'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 115353: Rename dbus interface files for solid
From:       "Stefano Avallone" <stavallo () unina ! it>
Date:       2014-01-28 14:12:35
Message-ID: 20140128141235.11809.23982 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115353/
-----------------------------------------------------------

(Updated Jan. 28, 2014, 2:12 p.m.)

Review request for KDE Frameworks.

Repository: solid

Description (updated)
-------

The dbus interface files installed by solid conflict with those installed \
by kdelib4. To allow co-installability of kde4 and kf5, rename the former \
by using the same approach adopted for kglobalaccess, kjobviewer, etc.

If this patch seems reasonable, I will submit the companion patch for \
kde-workspace.

Diffs
-----

  src/solid/CMakeLists.txt 84c254e 

Diff: https://git.reviewboard.kde.org/r/115353/diff/

Testing
-------

Builds and installs fine. I am not an expert of dbus interface files and \
cmake, so please check that this patch does not produce unwanted \
side-effects.

Thanks,

Stefano Avallone

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115353/">https://git.reviewboard.kde.org/r/115353/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Stefano Avallone.</div>

<p style="color: grey;"><i>Updated Jan. 28, 2014, 2:12 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The dbus interface files installed by solid conflict with \
those installed by kdelib4. To allow co-installability of kde4 and kf5, \
rename the former by using the same approach adopted for kglobalaccess, \
kjobviewer, etc.

If this patch seems reasonable, I will submit the companion patch for \
kde-workspace.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds and installs fine. I am not an expert of dbus interface \
files and cmake, so please check that this patch does not produce unwanted \
side-effects.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/solid/CMakeLists.txt <span style="color: \
grey">(84c254e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115353/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 