This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/

Ship it!

Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least bugreport?

- David Faure


On January 22nd, 2014, 5:51 p.m. UTC, Alexander Richardson wrote:

Review request for Build System, Extra Cmake Modules and KDE Frameworks.
By Alexander Richardson.

Updated Jan. 22, 2014, 5:51 p.m.

Repository: extra-cmake-modules

Description 

Only set QT_STRICT_ITERATORS when not compiling with MSVC

On MSVC linker errors will happen when this flag is set.

Testing 

E.g. KConfigWidgets didn't compile before, compiles now

Diffs

  • kde-modules/KDEFrameworkCompilerSettings.cmake (d71c407f9c0b504ebb1c0cf662e69545f7a46371)

View Diff