From kde-frameworks-devel Thu Jan 23 09:28:08 2014 From: "David Faure" Date: Thu, 23 Jan 2014 09:28:08 +0000 To: kde-frameworks-devel Subject: Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC Message-Id: <20140123092808.29157.69045 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=139046931430973 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8930505881435928621==" --===============8930505881435928621== Content-Type: multipart/alternative; boundary="===============6866954883003602490==" --===============6866954883003602490== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48092 ----------------------------------------------------------- Ship it! Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least bugreport? - David Faure On Jan. 22, 2014, 5:51 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115234/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 5:51 p.m.) > > > Review request for Build System, Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Only set QT_STRICT_ITERATORS when not compiling with MSVC > > On MSVC linker errors will happen when this flag is set. > > > Diffs > ----- > > kde-modules/KDEFrameworkCompilerSettings.cmake d71c407f9c0b504ebb1c0cf662e69545f7a46371 > > Diff: https://git.reviewboard.kde.org/r/115234/diff/ > > > Testing > ------- > > E.g. KConfigWidgets didn't compile before, compiles now > > > Thanks, > > Alexander Richardson > > --===============6866954883003602490== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/

Ship it!

Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least bugreport?

- David Faure

On January 22nd, 2014, 5:51 p.m. UTC, Alexander Richardson wrote:

Review request for Build System, Extra Cmake Modules and KDE Frameworks.

By Alexander Richardson.

Updated Jan. 22, 2014, 5:51 p.m.

Repository: extra-cmake-modules

Description

Only set QT_STRICT_ITERATORS when not compiling with MSVC

On MSVC linker errors will happen when this flag is set.

Testing

E.g. KConfigWidgets didn't compile before, compiles now

Diffs

kde-modules/KDEFrameworkCompilerSettings.cmake (d71c407f9c0b504ebb1c0cf662e69545f7a46371)

View Diff

--===============6866954883003602490==-- --===============8930505881435928621== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============8930505881435928621==--