[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 115078: don't install dbus interface files in kglobalaccel
From: "Martin Tobias Holmedahl Sandsmark" <martin.sandsmark () kde ! org>
Date: 2014-01-20 1:36:10
Message-ID: 20140120013610.13923.54619 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote:
> > this would break my workflow given that I install kde4 and kf5 to different \
> > prefixes. I think this needs a different approach, but please don't ask me for \
> > it. I'm lacking ideas how we could solve this upstream.
>
> Hrvoje Senjan wrote:
> What about just renaming xml files? Interfaces would be left compatible, and the \
> files would not conflict. Only it would look a bit ugly, and possibly confusing... \
> (To my knowledge, there is no rule/spec that xml must match interface name, but \
> that could be false ;-)
I think the idea is to move the xml file to kde-workspace somehow?
- Martin Tobias Holmedahl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review47614
-----------------------------------------------------------
On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115078/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2014, 4:07 p.m.)
>
>
> Review request for KDE Frameworks and Martin Gräßlin.
>
>
> Repository: kglobalaccel
>
>
> Description
> -------
>
> don't install dbus interface files in kglobalaccel, these overlap with the \
> equivalent files in kdelibs4 which causes problems for some distributions
>
> Diffs
> -----
>
> KF5GlobalAccelConfig.cmake.in 5f069d3
> src/CMakeLists.txt d48e92e
>
> Diff: https://git.reviewboard.kde.org/r/115078/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Riddell
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115078/">https://git.reviewboard.kde.org/r/115078/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 17th, 2014, 8:43 p.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this would break my workflow given that I install kde4 and kf5 to \
different prefixes. I think this needs a different approach, but please don't ask \
me for it. I'm lacking ideas how we could solve this upstream.</pre> \
</blockquote>
<p>On January 18th, 2014, 6:14 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about just renaming \
xml files? Interfaces would be left compatible, and the files would not conflict. \
Only it would look a bit ugly, and possibly confusing... (To my knowledge, there is \
no rule/spec that xml must match interface name, but that could be false ;-)</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the idea is to \
move the xml file to kde-workspace somehow? </pre> <br />
<p>- Martin Tobias Holmedahl</p>
<br />
<p>On January 17th, 2014, 4:07 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Martin Gräßlin.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2014, 4:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kglobalaccel
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">don't install dbus interface files in kglobalaccel, these overlap \
with the equivalent files in kdelibs4 which causes problems for some \
distributions</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KF5GlobalAccelConfig.cmake.in <span style="color: grey">(5f069d3)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(d48e92e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115078/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic