From kde-frameworks-devel Wed Jan 08 13:52:36 2014 From: =?ISO-8859-1?Q?Aur=E9lien_G=E2teau?= Date: Wed, 08 Jan 2014 13:52:36 +0000 To: kde-frameworks-devel Subject: Re: [PATCH] Fail early if libsm is not installed Message-Id: <3371705.E2jnFoSF6z () trinity> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=138918918529835 Le dimanche 29 d=E9cembre 2013 14:42:53 David Faure a =E9crit : > On Thursday 19 December 2013 18:10:11 Aur=E9lien G=E2teau wrote: > > Hi, > > = > > Attached patch causes cmake to fail early if libsm is not installed, > > rather > > than waiting until we try to build code using it. > > = > > This patch also removes buggy calls to set_package_properties(). I found > > out calling set_package_properties() with something which is not a > > package as the first argument is currently silently ignored. Note that > > this means the TYPE argument is ignored as well, so marking something as > > REQUIRED has no effect. > > = > > As a result I put together a poor-man feature_summary() implementation > > at the end of the CMakeLists.txt for X11 components. It's a bit overkill > > for the needs of kde4support, but can be duplicated or factorized > > later. > = > I can't comment on whether there's a better way to do this, but anyway, t= he > patch improves things so it should go in IMHO. Thanks, I just committed a simpler version of the patch, handling missing X= 11 = features the same way kidletime does. Aur=E9lien _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel