'Review Request 114908: Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 114908: Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS
From:       "Alex Merry" <kde () randomguy3 ! me ! uk>
Date:       2014-01-07 23:21:58
Message-ID: 20140107232158.28120.9061 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114908/
-----------------------------------------------------------

Review request for Build System and KDE Frameworks.

Repository: extra-cmake-modules

Description
-------

Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS

Setting the variable just leads to set() calls overwriting each other
accidentally (as appeared to have happened in the WIN32 block).

Diffs
-----

  kde-modules/KDECompilerSettings.cmake \
6adbc069bf314ae1a462ffbc5abe25264dac0ac2 

Diff: https://git.reviewboard.kde.org/r/114908/diff/

Testing
-------

KCoreAddons still compiles, and "make VERBOSE=1" shows that it is setting \
-D_BSD_SOURCE -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500, as \
expected.

Thanks,

Alex Merry

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114908/">https://git.reviewboard.kde.org/r/114908/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for Build System and KDE Frameworks.</div>
<div>By Alex Merry.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use add_definitions directly, instead of via \
_KDE4_PLATFORM_DEFINITIONS

Setting the variable just leads to set() calls overwriting each other
accidentally (as appeared to have happened in the WIN32 block).</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KCoreAddons still compiles, and &quot;make VERBOSE=1&quot; \
shows that it is setting -D_BSD_SOURCE -D_GNU_SOURCE -D_LARGEFILE64_SOURCE \
-D_XOPEN_SOURCE=500, as expected.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kde-modules/KDECompilerSettings.cmake <span style="color: \
grey">(6adbc069bf314ae1a462ffbc5abe25264dac0ac2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114908/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 