[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 114903: Do not set CMP0022
From: "Stephen Kelly" <steveire () gmail ! com>
Date: 2014-01-07 22:57:53
Message-ID: 20140107225753.16659.59223 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114903/#review47015
-----------------------------------------------------------
Ship it!
This didn't work at all because NO_POLICY_SCOPE is not used when finding \
it.
- Stephen Kelly
On Jan. 7, 2014, 8:57 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114903/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 8:57 p.m.)
>
>
> Review request for Build System, KDE Frameworks and Stephen Kelly.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Do not set CMP0022
>
> We do not want to suppress any warnings about LINK_INTERFACE_LIBRARIES
> vs INTERFACE_LINK_LIBRARIES; everything should be using the latter,
> since we depend on CMake 2.8.12 everywhere.
>
>
> Diffs
> -----
>
> kde-modules/KDECMakeSettings.cmake \
> 63cc90117a0a0655fa6e1db0f054235bb6333f29
> Diff: https://git.reviewboard.kde.org/r/114903/diff/
>
>
> Testing
> -------
>
> CMake runs fine (in a clean build dir) on KCoreAddons, KActivities (which \
> still triggers the warning, but I don't think includes this file anyway) \
> and plasma-frameworks.
>
> Thanks,
>
> Alex Merry
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114903/">https://git.reviewboard.kde.org/r/114903/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This didn't work at all because NO_POLICY_SCOPE is not \
used when finding it.</pre> <br />
<p>- Stephen Kelly</p>
<br />
<p>On January 7th, 2014, 8:57 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Build System, KDE Frameworks and Stephen \
Kelly.</div> <div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2014, 8:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Do not set CMP0022
We do not want to suppress any warnings about LINK_INTERFACE_LIBRARIES
vs INTERFACE_LINK_LIBRARIES; everything should be using the latter,
since we depend on CMake 2.8.12 everywhere.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">CMake runs fine (in a clean build dir) on KCoreAddons, \
KActivities (which still triggers the warning, but I don't think \
includes this file anyway) and plasma-frameworks.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDECMakeSettings.cmake <span style="color: \
grey">(63cc90117a0a0655fa6e1db0f054235bb6333f29)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114903/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic