[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 114904: Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake
From: "Alexander Neundorf" <neundorf () kde ! org>
Date: 2014-01-07 21:43:55
Message-ID: 20140107214355.28120.49086 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114904/#review47008
-----------------------------------------------------------
The motivation was that if somebody had set up carefully his install dirs for \
kdelibs, he simply wanted to point a following project to the same \
CMAKE_INSTALL_PREFIX, and have all the other install dirs automatically use the same \
locations as the installed kdelibs. Somebody, or maybe several people, requested this \
back then, I don't remember right now where or who it was.
- Alexander Neundorf
On Jan. 7, 2014, 9:18 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114904/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 9:18 p.m.)
>
>
> Review request for Build System and KDE Frameworks.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake
>
> This appears to be a hangover from the KDE4 days, which would adjust
> certain paths to match the ones for kdelibs if you installed an
> application to the same prefix as kdelibs. This was probably to make
> KStandardDirs work properly in unusual setups.
>
>
> Diffs
> -----
>
> kde-modules/KDEInstallDirs.cmake 838a52384b7cbfc84c5bd02c2f40f027f36db169
>
> Diff: https://git.reviewboard.kde.org/r/114904/diff/
>
>
> Testing
> -------
>
> CMake runs fine on KCoreAddons (clean build dir), and only the install prefix \
> variable I set on the command line (CMAKE_INSTALL_PREFIX) is in the cache.
>
> Thanks,
>
> Alex Merry
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114904/">https://git.reviewboard.kde.org/r/114904/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The motivation was that \
if somebody had set up carefully his install dirs for kdelibs, he simply wanted to \
point a following project to the same CMAKE_INSTALL_PREFIX, and have all the other \
install dirs automatically use the same locations as the installed kdelibs. Somebody, \
or maybe several people, requested this back then, I don't remember right now \
where or who it was. </pre>
<br />
<p>- Alexander Neundorf</p>
<br />
<p>On January 7th, 2014, 9:18 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Build System and KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2014, 9:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake
This appears to be a hangover from the KDE4 days, which would adjust
certain paths to match the ones for kdelibs if you installed an
application to the same prefix as kdelibs. This was probably to make
KStandardDirs work properly in unusual setups.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">CMake runs fine on KCoreAddons (clean build dir), and only the install \
prefix variable I set on the command line (CMAKE_INSTALL_PREFIX) is in the \
cache.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDEInstallDirs.cmake <span style="color: \
grey">(838a52384b7cbfc84c5bd02c2f40f027f36db169)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114904/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic