[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2013-12-09 21:30:47
Message-ID: 20131209213047.15595.64728 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114356/#review45435
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On Dec. 9, 2013, 3 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114356/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2013, 3 p.m.)
>
>
> Review request for KDE Frameworks and Martin Klapetek.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> New framework needs DBus, Widgets and (optionally) X11Extras as dependencies.
>
> @MartinK: how should we organize the renaming? I'm still using the old naming \
> scheme. So should I adjust or should we use your scripts after pulling this one in? \
>
> Diffs
> -----
>
> tier1/CMakeLists.txt 450ca57
> tier1/kglobalaccel/CMakeLists.txt PRE-CREATION
> tier1/kglobalaccel/KF5GlobalAccelConfig.cmake.in PRE-CREATION
> tier1/kglobalaccel/autotests/CMakeLists.txt PRE-CREATION
> tier1/kglobalaccel/autotests/kglobalshortcuttest.h PRE-CREATION
> tier1/kglobalaccel/autotests/kglobalshortcuttest.cpp PRE-CREATION
> tier1/kglobalaccel/src/CMakeLists.txt PRE-CREATION
> tier1/kglobalaccel/src/config-kglobalaccel.h.cmake PRE-CREATION
> tier1/kglobalaccel/src/kglobalaccel.h PRE-CREATION
> tier1/kglobalaccel/src/kglobalaccel.cpp PRE-CREATION
> tier1/kglobalaccel/src/kglobalaccel_p.h PRE-CREATION
> tier1/kglobalaccel/src/kglobalshortcutinfo.h PRE-CREATION
> tier1/kglobalaccel/src/kglobalshortcutinfo.cpp PRE-CREATION
> tier1/kglobalaccel/src/kglobalshortcutinfo_dbus.cpp PRE-CREATION
> tier1/kglobalaccel/src/kglobalshortcutinfo_p.h PRE-CREATION
> tier1/kglobalaccel/src/org.kde.KGlobalAccel.xml PRE-CREATION
> tier1/kglobalaccel/src/org.kde.kglobalaccel.Component.xml PRE-CREATION
> tier3/xmlgui/CMakeLists.txt 75593fb
> tier3/xmlgui/autotests/CMakeLists.txt 6546ac7
> tier3/xmlgui/autotests/kglobalshortcuttest.h d8e0024
> tier3/xmlgui/autotests/kglobalshortcuttest.cpp 453920b
> tier3/xmlgui/src/CMakeLists.txt 31621e2
> tier3/xmlgui/src/kactioncollection.cpp 0266069
> tier3/xmlgui/src/kglobalaccel.h 57482ad
> tier3/xmlgui/src/kglobalaccel.cpp 77ce993
> tier3/xmlgui/src/kglobalaccel_p.h 50f271f
> tier3/xmlgui/src/kglobalshortcutinfo.h 0920f01
> tier3/xmlgui/src/kglobalshortcutinfo.cpp d2ca948
> tier3/xmlgui/src/kglobalshortcutinfo_dbus.cpp f49bd9d
> tier3/xmlgui/src/kglobalshortcutinfo_p.h dd2dd2d
> tier3/xmlgui/src/kkeysequencewidget.cpp 2148ce0
> tier3/xmlgui/src/kshortcutseditor.cpp 3e917d2
> tier3/xmlgui/src/kshortcutseditoritem.cpp e7257a6
> tier3/xmlgui/src/kxmlguifactory.cpp 510d2ea
> tier3/xmlgui/src/org.kde.KGlobalAccel.xml 8746551
> tier3/xmlgui/src/org.kde.kglobalaccel.Component.xml ec21201
> tier4/kde4support/CMakeLists.txt cb73b46
> tier4/kde4support/src/CMakeLists.txt 39298b9
> tier4/khtml/CMakeLists.txt c937f38
> tier4/khtml/src/CMakeLists.txt 00243fb
>
> Diff: http://git.reviewboard.kde.org/r/114356/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114356/">http://git.reviewboard.kde.org/r/114356/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Kevin Ottens</p>
<br />
<p>On December 9th, 2013, 3 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Martin Klapetek.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Dec. 9, 2013, 3 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">New framework needs DBus, Widgets and (optionally) X11Extras as \
dependencies.
@MartinK: how should we organize the renaming? I'm still using the old naming \
scheme. So should I adjust or should we use your scripts after pulling this one \
in?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/CMakeLists.txt <span style="color: grey">(450ca57)</span></li>
<li>tier1/kglobalaccel/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/KF5GlobalAccelConfig.cmake.in <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/autotests/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/autotests/kglobalshortcuttest.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/autotests/kglobalshortcuttest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/config-kglobalaccel.h.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/kglobalaccel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/kglobalaccel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/kglobalaccel_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/kglobalshortcutinfo.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/kglobalshortcutinfo.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/kglobalshortcutinfo_dbus.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/kglobalshortcutinfo_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/org.kde.KGlobalAccel.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/org.kde.kglobalaccel.Component.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier3/xmlgui/CMakeLists.txt <span style="color: grey">(75593fb)</span></li>
<li>tier3/xmlgui/autotests/CMakeLists.txt <span style="color: \
grey">(6546ac7)</span></li>
<li>tier3/xmlgui/autotests/kglobalshortcuttest.h <span style="color: \
grey">(d8e0024)</span></li>
<li>tier3/xmlgui/autotests/kglobalshortcuttest.cpp <span style="color: \
grey">(453920b)</span></li>
<li>tier3/xmlgui/src/CMakeLists.txt <span style="color: grey">(31621e2)</span></li>
<li>tier3/xmlgui/src/kactioncollection.cpp <span style="color: \
grey">(0266069)</span></li>
<li>tier3/xmlgui/src/kglobalaccel.h <span style="color: grey">(57482ad)</span></li>
<li>tier3/xmlgui/src/kglobalaccel.cpp <span style="color: \
grey">(77ce993)</span></li>
<li>tier3/xmlgui/src/kglobalaccel_p.h <span style="color: \
grey">(50f271f)</span></li>
<li>tier3/xmlgui/src/kglobalshortcutinfo.h <span style="color: \
grey">(0920f01)</span></li>
<li>tier3/xmlgui/src/kglobalshortcutinfo.cpp <span style="color: \
grey">(d2ca948)</span></li>
<li>tier3/xmlgui/src/kglobalshortcutinfo_dbus.cpp <span style="color: \
grey">(f49bd9d)</span></li>
<li>tier3/xmlgui/src/kglobalshortcutinfo_p.h <span style="color: \
grey">(dd2dd2d)</span></li>
<li>tier3/xmlgui/src/kkeysequencewidget.cpp <span style="color: \
grey">(2148ce0)</span></li>
<li>tier3/xmlgui/src/kshortcutseditor.cpp <span style="color: \
grey">(3e917d2)</span></li>
<li>tier3/xmlgui/src/kshortcutseditoritem.cpp <span style="color: \
grey">(e7257a6)</span></li>
<li>tier3/xmlgui/src/kxmlguifactory.cpp <span style="color: \
grey">(510d2ea)</span></li>
<li>tier3/xmlgui/src/org.kde.KGlobalAccel.xml <span style="color: \
grey">(8746551)</span></li>
<li>tier3/xmlgui/src/org.kde.kglobalaccel.Component.xml <span style="color: \
grey">(ec21201)</span></li>
<li>tier4/kde4support/CMakeLists.txt <span style="color: grey">(cb73b46)</span></li>
<li>tier4/kde4support/src/CMakeLists.txt <span style="color: \
grey">(39298b9)</span></li>
<li>tier4/khtml/CMakeLists.txt <span style="color: grey">(c937f38)</span></li>
<li>tier4/khtml/src/CMakeLists.txt <span style="color: grey">(00243fb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114356/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic